Skip to content

fix: Include git in feast server image#6279

Open
ntkathole wants to merge 1 commit intomasterfrom
include_git
Open

fix: Include git in feast server image#6279
ntkathole wants to merge 1 commit intomasterfrom
include_git

Conversation

@ntkathole
Copy link
Copy Markdown
Member

@ntkathole ntkathole commented Apr 14, 2026

Root cause: PR #6217 switched Docker images from ubi9/python-312:1 (full UBI) to ubi9/python-312-minimal:1. The full image includes git by default; the minimal image does not. The PR added other system packages (gcc, libpq-devel, etc.) via microdnf but missed git.

Impact: The feast operator's init container uses git clone to set up the feature repository when feastProjectDir.Git is configured (see setInitContainer in services.go). Without git in the image, this fails with git: command not found.

Why tests didn't catch it: The operator's unit tests verify that the init container spec is constructed correctly (correct command, args, env vars), but they don't actually run the container. The missing git binary is a runtime issue inside the actual Docker image, which no existing test exercises.


Open with Devin

@ntkathole ntkathole self-assigned this Apr 14, 2026
@ntkathole ntkathole requested a review from a team as a code owner April 14, 2026 17:13
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant