Skip to content

fix: Include StreamFeatureView in freshness metric #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Apr 13, 2026
Merged

fix: Include StreamFeatureView in freshness metric #6269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65cb0c1
added stream_fv
Vperiodt Apr 13, 2026
9eff634
nit
Vperiodt Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/feast/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,10 @@ def update_feature_freshness(
"""
try:
feature_views = store.list_feature_views(allow_cache=True)
stream_feature_views = store.list_stream_feature_views(allow_cache=True)
all_views = feature_views + stream_feature_views
now = datetime.now(tz=timezone.utc)
for fv in feature_views:
for fv in all_views:
end_time = fv.most_recent_end_time
if end_time is not None:
if end_time.tzinfo is None:
Expand Down
14 changes: 14 additions & 0 deletions sdk/python/tests/unit/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,16 @@ def test_sets_freshness_for_materialized_views(self):
minutes=5
)

mock_sfv = MagicMock()
mock_sfv.name = "test_sfv"
mock_sfv.most_recent_end_time = datetime.now(tz=timezone.utc) - timedelta(
minutes=5
)

mock_store = MagicMock()
mock_store.project = "test_project"
mock_store.list_feature_views.return_value = [mock_fv]
mock_store.list_stream_feature_views.return_value = [mock_sfv]

update_feature_freshness(mock_store)

Expand All @@ -504,6 +511,11 @@ def test_sets_freshness_for_materialized_views(self):
)._value.get()
assert 280 < staleness < 320

sfv_staleness = feature_freshness_seconds.labels(
feature_view="test_sfv", project="test_project"
)._value.get()
assert 280 < sfv_staleness < 320

def test_skips_unmaterialized_views(self):
mock_fv = MagicMock()
mock_fv.name = "unmaterialized_fv"
Expand All @@ -512,6 +524,7 @@ def test_skips_unmaterialized_views(self):
mock_store = MagicMock()
mock_store.project = "test_project"
mock_store.list_feature_views.return_value = [mock_fv]
mock_store.list_stream_feature_views.return_value = []

update_feature_freshness(mock_store)

Expand All @@ -525,6 +538,7 @@ def test_handles_naive_datetime(self):
mock_store = MagicMock()
mock_store.project = "test_project"
mock_store.list_feature_views.return_value = [mock_fv]
mock_store.list_stream_feature_views.return_value = []

update_feature_freshness(mock_store)

Expand Down
Loading