Skip to content

feat: Migrate MCP server from fastapi_mcp to MCP Python SDK #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patelchaitany wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Migrate MCP server from fastapi_mcp to MCP Python SDK #6258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,14 @@ async def lifespan(app: FastAPI):

await store.initialize()
async_refresh()

mcp_sm = getattr(app.state, "mcp_session_manager", None)
try:
yield
if mcp_sm:
async with mcp_sm.run():
yield
else:
yield
finally:
stop_refresh()
if offline_batcher is not None:
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/mcp_servers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# MCP (Model Context Protocol) server implementations for Feast

from .mcp_config import McpFeatureServerConfig
from .mcp_server import add_mcp_support_to_app
from .mcp_server import add_mcp_support_to_app, create_mcp_server

__all__ = [
"McpFeatureServerConfig",
"add_mcp_support_to_app",
"create_mcp_server",
]
7 changes: 2 additions & 5 deletions sdk/python/feast/infra/mcp_servers/mcp_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,16 @@
class McpFeatureServerConfig(BaseFeatureServerConfig):
"""MCP (Model Context Protocol) Feature Server configuration."""

# Feature server type selector
type: Literal["mcp"] = "mcp"

# Enable MCP server support - defaults to False as requested
mcp_enabled: StrictBool = False

# MCP server name for identification
mcp_server_name: StrictStr = "feast-mcp-server"

# MCP server version
mcp_server_version: StrictStr = "1.0.0"

mcp_transport: Literal["sse", "http"] = "sse"

# The endpoint definition for transformation_service (inherited from base)
mcp_base_path: StrictStr = "/mcp"

transformation_service_endpoint: StrictStr = "localhost:6566"
Loading
Loading