Skip to content

feat: Phase 1 - Added different data modes to UI server #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntkathole wants to merge 1 commit into
base: master
Choose a base branch
from
+508 −63
Open

feat: Phase 1 - Added different data modes to UI server #6223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion sdk/python/feast/cli/ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

from feast.repo_operations import create_feature_store, registry_dump

VALID_MODES = ("proto", "rest", "rest-external")


@click.command()
@click.option(
Expand Down Expand Up @@ -52,6 +54,25 @@
show_default=False,
help="path to TLS(SSL) certificate public key. You need to pass --key arg as well to start server in TLS mode",
)
@click.option(
"--mode",
"-m",
type=click.Choice(VALID_MODES, case_sensitive=False),
default="proto",
show_default=True,
help=(
"Data serving mode for the UI. "
"'proto' serves the registry as a protobuf blob (current default). "
"'rest' mounts the REST registry API alongside the UI. "
"'rest-external' proxies to an external REST registry API."
),
)
@click.option(
"--rest-api-url",
type=click.STRING,
default="",
help="Base URL of an external REST registry API (required when --mode=rest-external). Example: http://registry-host:6570/api/v1",
)
@click.pass_context
def ui(
ctx: click.Context,
Expand All @@ -61,6 +82,8 @@ def ui(
root_path: str = "",
tls_key_path: str = "",
tls_cert_path: str = "",
mode: str = "proto",
rest_api_url: str = "",
):
"""
Shows the Feast UI over the current directory
Expand All @@ -69,8 +92,11 @@ def ui(
raise click.BadParameter(
"Please configure --key and --cert args to start the feature server in SSL mode."
)
if mode == "rest-external" and not rest_api_url:
raise click.BadParameter(
"--rest-api-url is required when using --mode=rest-external."
)
store = create_feature_store(ctx)
# Pass in the registry_dump method to get around a circular dependency
store.serve_ui(
host=host,
port=port,
Expand All @@ -79,4 +105,6 @@ def ui(
root_path=root_path,
tls_key_path=tls_key_path,
tls_cert_path=tls_cert_path,
mode=mode,
rest_api_url=rest_api_url,
)
11 changes: 10 additions & 1 deletion sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3153,8 +3153,15 @@ def serve_ui(
root_path: str = "",
tls_key_path: str = "",
tls_cert_path: str = "",
mode: str = "proto",
rest_api_url: str = "",
) -> None:
"""Start the UI server locally"""
"""Start the UI server locally

Args:
mode: Data serving mode - 'proto' (default), 'rest', or 'rest-external'.
rest_api_url: Base URL for external REST API (required for 'rest-external' mode).
"""
if flags_helper.is_test():
warnings.warn(
"The Feast UI is an experimental feature. "
Expand All @@ -3171,6 +3178,8 @@ def serve_ui(
root_path=root_path,
tls_key_path=tls_key_path,
tls_cert_path=tls_cert_path,
mode=mode,
rest_api_url=rest_api_url,
)

def serve_registry(
Expand Down
Loading
Loading