Skip to content

feat: Add versioning support for FAISS online store #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpathade wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Add versioning support for FAISS online store #6196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
286e5dc
Removed unnecessary lazy imports
rpathade Mar 30, 2026
c38454a
Resolve suggestions
rpathade Apr 2, 2026
fe8c270
fix: move mutable class attrs to __init__ in FaissOnlineStore
rpathade Apr 2, 2026
cbb1088
Resolve error message
rpathade Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve suggestions 
Signed-off-by: RutujaPathade <73137503+RutujaPathade@users.noreply.github.com>
  • Loading branch information
@rpathade
rpathade committed Apr 2, 2026
commit c38454aa153212ce6625ff2f2f2facb33cfa96a3
9 changes: 6 additions & 3 deletions sdk/python/feast/infra/online_stores/faiss_online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ def _table_id(project: str, table: FeatureView, enable_versioning: bool = False)


class FaissOnlineStore(OnlineStore):
_indices: Dict[str, faiss.IndexIVFFlat] = {}
_in_memory_stores: Dict[str, InMemoryStore] = {}
_config: Optional[FaissOnlineStoreConfig] = None
_logger: logging.Logger = logging.getLogger(__name__)

def __init__(self):
super().__init__()
self._indices: Dict[str, faiss.IndexIVFFlat] = {}
self._in_memory_stores: Dict[str, InMemoryStore] = {}
self._config: Optional[FaissOnlineStoreConfig] = None

def _get_index(
self, table_key: str
) -> Optional[faiss.IndexIVFFlat]:
Expand Down
10 changes: 8 additions & 2 deletions sdk/python/feast/infra/online_stores/online_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,16 @@ def get_online_features(

def _check_versioned_read_support(self, grouped_refs):
"""Raise an error if versioned reads are attempted on unsupported stores."""
from feast.infra.online_stores.faiss_online_store import FaissOnlineStore
try:
from feast.infra.online_stores.faiss_online_store import FaissOnlineStore
except ImportError:
FaissOnlineStore = None
from feast.infra.online_stores.sqlite import SqliteOnlineStore

if isinstance(self, (SqliteOnlineStore, FaissOnlineStore)):
supported = [SqliteOnlineStore]
if FaissOnlineStore is not None:
supported.append(FaissOnlineStore)
if isinstance(self, tuple(supported)):
Comment thread
rpathade marked this conversation as resolved.
return
for table, _ in grouped_refs:
version_tag = getattr(table.projection, "version_tag", None)
Expand Down