Skip to content

Generate golang code for non-serving protos #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Apr 14, 2020
Merged

Generate golang code for non-serving protos #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e8983f
Generate golang code for non-serving protos as well
Apr 14, 2020
c62366e
Generate code with protoc 3.10.0
Apr 14, 2020
94f8b84
Unnest from third_party dir
Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ install-go-ci-dependencies:
go get -u golang.org/x/lint/golint

compile-protos-go: install-go-ci-dependencies
@$(foreach dir,types serving, cd ${ROOT_DIR}/protos; protoc -I/usr/local/include -I. --go_out=plugins=grpc,paths=source_relative:../sdk/go/protos/ feast/$(dir)/*.proto;)
cd ${ROOT_DIR}/protos; protoc -I/usr/local/include -I. --go_out=plugins=grpc,paths=source_relative:../sdk/go/protos/ tensorflow_metadata/proto/v0/*.proto
$(foreach dir,types serving core storage,cd ${ROOT_DIR}/protos; protoc -I/usr/local/include -I. --go_out=plugins=grpc,paths=source_relative:../sdk/go/protos feast/$(dir)/*.proto;)

test-go:
cd ${ROOT_DIR}/sdk/go; go test ./...
Expand Down
1 change: 1 addition & 0 deletions protos/tensorflow_metadata/proto/v0/path.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package tensorflow.metadata.v0;

option java_package = "org.tensorflow.metadata.v0";
option java_multiple_files = true;
option go_package = "github.com/gojek/feast/sdk/go/protos/tensorflow_metadata/proto/v0";

// A path is a more general substitute for the name of a field or feature that
// can be used for flat examples as well as structured data. For example, if
Expand Down
1 change: 1 addition & 0 deletions protos/tensorflow_metadata/proto/v0/schema.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import "tensorflow_metadata/proto/v0/path.proto";
option cc_enable_arenas = true;
option java_package = "org.tensorflow.metadata.v0";
option java_multiple_files = true;
option go_package = "github.com/gojek/feast/sdk/go/protos/tensorflow_metadata/proto/v0";

// LifecycleStage. Only UNKNOWN_STAGE, BETA, and PRODUCTION features are
// actually validated.
Expand Down
Loading