Skip to content

feat: Support nested collection types (Array/Set of Array/Set) (#5947) #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 10 commits into from
Apr 2, 2026
Merged

feat: Support nested collection types (Array/Set of Array/Set) (#5947) #6132

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5425a92
feat: Support nested collection types (Array/Set of Array/Set) (#5947)
soooojinlee Mar 17, 2026
734aee6
fix: Fix remote online read for nested collection types and add docs
soooojinlee Mar 18, 2026
e57ddd2
fix: Fix JSON deserialization, schema inference, and silent fallback …
soooojinlee Mar 18, 2026
36fdf4e
fix: Fix mypy type error in nested collection proto construction
soooojinlee Mar 19, 2026
3c81d5e
fix: Fix equality comparison for nested types and JSON deserializatio…
soooojinlee Mar 26, 2026
4dabd1b
feat: Remove depth limit for nested collection types and improve test…
soooojinlee Mar 26, 2026
fd0d745
refactor: Replace combinatorial nested collection enums with recursiv…
soooojinlee Mar 28, 2026
89379fc
fix: Preserve inner element types in PyArrow schema inference and opt…
soooojinlee Apr 1, 2026
a4dde0f
fix: Add np.ndarray support in nested collection proto conversion and…
soooojinlee Apr 1, 2026
646b6bc
Merge branch 'master' into feat/support-nested-collection-types
franciscojavierarceo Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix mypy type error in nested collection proto construction 
Use getattr/CopyFrom instead of **dict unpacking for ProtoValue
construction to satisfy mypy's strict type checking.

Signed-off-by: soojin <soojin@dable.io>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: soojin <soojin@dable.io>
  • Loading branch information
@soooojinlee @claude @ntkathole
2 people authored and ntkathole committed Apr 2, 2026
commit 36fdf4e4be14575717519db2598dd19dbfe6aef6
3 changes: 2 additions & 1 deletion sdk/python/feast/type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,8 @@ def _convert_nested_collection_to_proto(
)
inner_values.append(proto_vals[0])
repeated = RepeatedValue(val=inner_values)
proto = ProtoValue(**{val_attr: repeated})
proto = ProtoValue()
getattr(proto, val_attr).CopyFrom(repeated)
result.append(proto)
return result

Expand Down