Skip to content

feat: Add typed_features field to grpc write request ((#6117) #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 11 commits into from
Mar 17, 2026
Merged

feat: Add typed_features field to grpc write request ((#6117) #6118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c7757a
feat: add typed_features field to PushRequest and WriteToOnlineStoreR…
nickquinn408 Mar 16, 2026
51eccb7
Devin feedback
nickquinn408 Mar 16, 2026
e597bc9
feat: Add typed_features field to grpc write request (#6117)
nickquinn408 Mar 16, 2026
ea1fdb6
fix: Revert generated proto files to CI-compatible version
nickquinn408 Mar 16, 2026
d093bc6
fix: Fix GrpcServer_pb2 typed_features stub and import paths
nickquinn408 Mar 16, 2026
74176e9
style: Apply ruff line-length formatting to grpc_server.py
nickquinn408 Mar 16, 2026
9ba35ea
Unwrap compound protobuf Value types in parse_typed
nickquinn408 Mar 16, 2026
04d55a0
feat: Support distinct count aggregation [#6116]
nquinn408 Mar 16, 2026
d9b6603
Merge branch 'master' into grpc-write-complex-types
nquinn408 Mar 17, 2026
58caf5c
Merge branch 'master' into grpc-write-complex-types
franciscojavierarceo Mar 17, 2026
4f501da
Merge branch 'master' into grpc-write-complex-types
franciscojavierarceo Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Devin feedback 
Signed-off-by: Nick Quinn <nicholas_quinn@apple.com>
  • Loading branch information
@nickquinn408
nickquinn408 committed Mar 16, 2026
commit 51eccb7a456e536f908e63ce750a843c28d727e2
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/contrib/grpc_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def parse_typed(typed_features):
df = {}
for key, value in typed_features.items():
val_case = value.WhichOneof("val")
df[key] = [getattr(value, val_case) if val_case is not None else None]
df[key] = [None if val_case is None or val_case == "null_val" else getattr(value, val_case)]
return pd.DataFrame.from_dict(df)


Expand Down
19 changes: 18 additions & 1 deletion sdk/python/tests/unit/test_grpc_server_write_protos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import pytest

from feast.infra.contrib.grpc_server import parse_typed
from feast.protos.feast.serving.GrpcServer_pb2 import (
PushRequest,
WriteToOnlineStoreRequest,
)
from feast.protos.feast.types.Value_pb2 import Value
from feast.protos.feast.types.Value_pb2 import Null, Value


def test_push_request_string_features():
Expand Down Expand Up @@ -88,3 +89,19 @@ def test_write_to_online_store_string_and_typed_features_are_independent():
r2 = WriteToOnlineStoreRequest(typed_features={"driver_id": Value(int64_val=1001)}, feature_view_name="fv")
assert len(r1.typed_features) == 0
assert len(r2.features) == 0


def test_parse_typed_null_val_becomes_none():
"""Value(null_val=NULL) must produce None in the DataFrame, not the integer 0."""
df = parse_typed({
"present": Value(int64_val=42),
"missing": Value(null_val=Null.NULL),
})
assert df["present"].iloc[0] == 42
assert df["missing"].iloc[0] is None


def test_parse_typed_unset_val_becomes_none():
"""A Value with no oneof field set (WhichOneof returns None) must also produce None."""
df = parse_typed({"empty": Value()})
assert df["empty"].iloc[0] is None
Loading