-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Extended OIDC support to extract groups & namespaces and token injection with multiple methods #6089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extended OIDC support to extract groups & namespaces and token injection with multiple methods #6089
Changes from all commits
493a6b9
3db6db3
0d59eca
36a5b06
a478a80
1483c6c
34474af
505d6de
5c79fcf
e0359db
7453349
4b4c1dd
1353482
86c9d76
5621f07
b5db157
1331057
a875169
7e59a53
611607b
3c1e36b
c2c4863
eed8b02
593b95d
a1c75de
88a389b
f632686
45666da
0a59ad2
3557a15
30a04c2
a967bc6
c1d7c11
8aae62a
cacd649
9200dd3
141c871
bd81904
66c3677
bb6fb52
2f3e7b9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ metadata: | |
| } | ||
| ] | ||
| capabilities: Basic Install | ||
| createdAt: "2026-03-10T20:00:10Z" | ||
| createdAt: "2026-04-07T13:49:25Z" | ||
| operators.operatorframework.io/builder: operator-sdk-v1.38.0 | ||
| operators.operatorframework.io/project_layout: go.kubebuilder.io/v4 | ||
| name: feast-operator.v0.61.0 | ||
|
|
@@ -175,6 +175,17 @@ spec: | |
| - get | ||
| - patch | ||
| - update | ||
| - apiGroups: | ||
| - monitoring.coreos.com | ||
| resources: | ||
| - servicemonitors | ||
| verbs: | ||
| - create | ||
| - delete | ||
| - get | ||
| - list | ||
| - patch | ||
| - watch | ||
| - apiGroups: | ||
| - policy | ||
| resources: | ||
|
|
@@ -259,6 +270,7 @@ spec: | |
| value: quay.io/feastdev/feature-server:0.61.0 | ||
| - name: RELATED_IMAGE_CRON_JOB | ||
| value: quay.io/openshift/origin-cli:4.17 | ||
| - name: OIDC_ISSUER_URL | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 OIDC_ISSUER_URL env var missing In the operator's OLM bundle CSV at line 273, the Expected vs actual YAML structureExpected (from config/manager/manager.yaml): - name: OIDC_ISSUER_URL
value: ""
image: quay.io/feastdev/feast-operator:0.61.0Actual (bundle CSV): - name: OIDC_ISSUER_URL
image: quay.io/feastdev/feast-operator:0.61.0Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. operator-sdk generate bundle strips value: "" from env vars by design. This is a known operator-sdk behavior as it considers value: "" equivalent to absent and removes it during YAML serialization. The source manager.yaml has value: "", kustomize build (install.yaml) preserves it, but operator-sdk (CSV) strips it. |
||
| image: quay.io/feastdev/feast-operator:0.61.0 | ||
| livenessProbe: | ||
| httpGet: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support OIDC token passing from ODH Notebook instead of service account token ? This we alreayd support for kubernetes token.
Not a blocker though, just for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this PR enables that. When a workbench notebook uses auth: {type: oidc}, the SDK's get_token() supports multiple token sources:
The server handles both. OIDC JWTs are validated against Keycloak JWKS, and SA tokens are detected via the kubernetes.io claim and validated via TokenReview. So both human OIDC tokens and SA tokens work from ODH Notebooks.