Skip to content

perf(postgres): Optimizing feast offline Store for date-range multi-FV retrieval #6057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vperiodt wants to merge 15 commits into
base: master
Choose a base branch
from
+629 −243
Open

perf(postgres): Optimizing feast offline Store for date-range multi-FV retrieval #6057

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
309cdac
Optimizing Date-Range Queries
Vperiodt Mar 4, 2026
3da5af3
fix issues
Vperiodt Mar 4, 2026
34eed9a
fix lint
Vperiodt Mar 4, 2026
a4139b7
featureview entities
Vperiodt Mar 9, 2026
74a474c
fix LOCF spine UNION and empty-entity SQL
Vperiodt Mar 9, 2026
6f754b8
added fixes
Vperiodt Mar 16, 2026
7594205
updates test
Vperiodt Mar 16, 2026
f770c41
fix entity_df range
Vperiodt Mar 16, 2026
f235eb8
updated postgres.py
Vperiodt Mar 16, 2026
8c66e6f
fix-lint
Vperiodt Apr 10, 2026
25bc86d
Merge branch 'feast-dev:master' into patch-query
Vperiodt Apr 16, 2026
b6a4703
address reviews
Vperiodt Apr 16, 2026
d014b09
Merge branch 'feast-dev:master' into patch-query
Vperiodt Apr 16, 2026
69565bb
lint-fix
Vperiodt Apr 16, 2026
b5d7c8f
Merge branch 'feast-dev:master' into patch-query
Vperiodt Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix entity_df range 
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
  • Loading branch information
@Vperiodt
Vperiodt committed Apr 10, 2026
commit f770c41c065651ba441287664d262fe41da5e973
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def get_historical_features(
# min_event_timestamp (= range[0] - TTL) doesn't clip the window.
# The synthetic entity_df only has end_date, which would wrongly
# set min_event_timestamp to end_date - TTL instead of start_date - TTL.
if start_date is not None and end_date is not None:
if skip_entity_upload and start_date is not None and end_date is not None:
entity_df_event_timestamp_range = (start_date, end_date)
else:
entity_df_event_timestamp_range = _get_entity_df_event_timestamp_range(
Expand Down