Skip to content

fix: Ray offline store tests are duplicated across 3 workflows - #6045

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:fix_ray_duplication
Mar 3, 2026
Merged

fix: Ray offline store tests are duplicated across 3 workflows#6045
ntkathole merged 1 commit into
feast-dev:masterfrom
ntkathole:fix_ray_duplication

Conversation

@ntkathole

@ntkathole ntkathole commented Mar 3, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Ray offline store tests were running 3 times across different workflows, and Ray compute engine tests were running in the main CI instead of the dedicated Ray workflow.

  • Removed the try/except block that conditionally appended RayDataSourceCreator to AVAILABLE_OFFLINE_STORES. This was the root cause - Ray was being auto-included in every workflow where it was installable.
  • Changed online store from RedisOnlineStoreCreator to {"type": "sqlite"}. The compute engine tests focus on Ray compute, not online store behavior, so sqlite is sufficient and avoids needing redis in the pixi environment.
  • Split the single test task into test-offline and test-compute, then combined them with depends-on. The Ray workflow now runs both sdk/python/tests/integration/offline_store (with Ray config) and sdk/python/tests/integration/compute_engines/ray_compute.
  • Added --ignore=sdk/python/tests/integration/compute_engines/ray_compute to test-python-integration (main CI target).
  • Replaced test-python-universal-ray-offline and test-python-ray-compute-engine with a single test-python-ray-integration target.
Open with Devin

@ntkathole ntkathole self-assigned this Mar 3, 2026
@ntkathole
ntkathole requested a review from a team as a code owner March 3, 2026 05:04
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Mar 3, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@tokoko

tokoko commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

#6043 partly fixes this as well

@ntkathole

ntkathole commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

#6043 partly fixes this as well

let's merge yours first and then will rebase

@ntkathole
ntkathole force-pushed the fix_ray_duplication branch from dce1337 to 9237461 Compare March 3, 2026 06:42
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@ntkathole
ntkathole force-pushed the fix_ray_duplication branch 2 times, most recently from 8630e59 to edb2b0c Compare March 3, 2026 07:08
@ntkathole
fix: Ray offline store tests are duplicated across 3 workflows
c9c3c47 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole
ntkathole force-pushed the fix_ray_duplication branch from edb2b0c to c9c3c47 Compare March 3, 2026 07:18
tokoko
tokoko approved these changes Mar 3, 2026
View reviewed changes

@tokoko tokoko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. you can ignore registry test fail, not sure how that slipped through. let's take care of other issues separately.

@ntkathole
ntkathole merged commit 54f705a into feast-dev:master Mar 3, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@tokoko tokoko tokoko approved these changes

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ntkathole @tokoko