Skip to content

chore: Run registry tests separately - #6043

Merged
tokoko merged 4 commits into
feast-dev:masterfrom
tokoko:cleanup-registry-tests
Mar 3, 2026
Merged

chore: Run registry tests separately#6043
tokoko merged 4 commits into
feast-dev:masterfrom
tokoko:cleanup-registry-tests

Conversation

@tokoko

@tokoko tokoko commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

  • Runs registry tests in a separate workflow
  • both integration and integration-local now ignore registration folder
  • other misc changes to concentrate all tests with universal_offline_stores marker under offline_store and with universal_online_stores marker under online_store.

Open with Devin

Signed-off-by: tokoko <togurgenidze@gmail.com>
@tokoko
tokoko requested a review from a team as a code owner March 2, 2026 18:03

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Signed-off-by: tokoko <togurgenidze@gmail.com>

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

run: |
echo "Running Registry REST API tests..."
uv run pytest sdk/python/tests/integration/registration/rest_api/test_registry_rest_api.py --integration -s
cd sdk/python && uv run pytest tests/integration/rest_api/test_registry_rest_api.py --integration -s

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is causing failure in CI.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that, but both remote and rest api tests are still failing for some other (pre-existing) reasons. I'll still merge and let's take care of other failures separately.

Signed-off-by: tokoko <togurgenidze@gmail.com>
@tokoko
tokoko merged commit 867fca7 into feast-dev:master Mar 3, 2026
24 of 27 checks passed
ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request Mar 16, 2026
* chore: Run registry tests separately

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: various fixes

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: registry api tests

Signed-off-by: tokoko <togurgenidze@gmail.com>

---------

Signed-off-by: tokoko <togurgenidze@gmail.com>
ntkathole pushed a commit to red-hat-data-services/feast that referenced this pull request Mar 16, 2026
* chore: Run registry tests separately

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: various fixes

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: registry api tests

Signed-off-by: tokoko <togurgenidze@gmail.com>

---------

Signed-off-by: tokoko <togurgenidze@gmail.com>
Shizoqua pushed a commit to Shizoqua/feast that referenced this pull request Mar 18, 2026
* chore: Run registry tests separately

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: various fixes

Signed-off-by: tokoko <togurgenidze@gmail.com>

* fix: registry api tests

Signed-off-by: tokoko <togurgenidze@gmail.com>

---------

Signed-off-by: tokoko <togurgenidze@gmail.com>
Signed-off-by: Shizoqua <hr.lanreshittu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants