Formatting

Signed-off-by: Casey Clements <casey.clements@mongodb.com>
feast-dev · ntkathole · Mar 10, 2026 · Jan 20, 2026 · Jan 20, 2026 · Feb 12, 2026
commit a6db5c7727ab283ed3957e2dd61e805c7ad22d3a
diff --git a/sdk/python/feast/infra/online_stores/contrib/mongodb_online_store/__init__.py b/sdk/python/feast/infra/online_stores/contrib/mongodb_online_store/__init__.py
@@ -1,3 +1,3 @@
 from .mongodb import MongoDBOnlineStore, MongoDBOnlineStoreConfig
 
-__all__ = ["MongoDBOnlineStore", "MongoDBOnlineStoreConfig"]
+__all__ = ["MongoDBOnlineStore", "MongoDBOnlineStoreConfig"]
diff --git a/sdk/python/feast/infra/online_stores/contrib/mongodb_online_store/mongodb.py b/sdk/python/feast/infra/online_stores/contrib/mongodb_online_store/mongodb.py
@@ -14,8 +14,10 @@
 from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
 from feast.protos.feast.types.Value_pb2 import Value as ValueProto
 from feast.repo_config import FeastConfigBaseModel, RepoConfig
-from feast.type_map import python_values_to_proto_values, feast_value_type_to_python_type
-
+from feast.type_map import (
+    feast_value_type_to_python_type,
+    python_values_to_proto_values,
+)
 
 logger = logging.getLogger(__name__)
 
@@ -165,79 +167,6 @@ def online_read(
             results.append((ts, features_proto))
         return results
 
-            # todo v inefficient: the method below must infer types. additionally we're iterating over rows
-            #  feature.dtype is held in table.feature.dtype.
-        """
-            Feast’s online read is row-oriented in output, but type conversion is naturally column-oriented.
-            Instead of:
-                For each entity → convert each feature individually
-            You should:
-                1.	Gather values for a single feature across all entities.
-                2.	Convert them in one call.
-                3.	Then reassemble row-wise.
-
-            Efficient Pattern
-            Assume: 
-                •	ids is ordered
-                •	requested_features is defined (handle case)
-                •	docs is your _id -> doc mapping
-            Step 1: Extract raw values column-wise
-
-
-            # Step 1: Extract raw values column-wise # (aligned by ordered ids column-wise)
-            raw_feature_columns = {feature: [] for feature in requested_features}
-
-            for entity_id in ids:
-                doc = docs.get(entity_id)
-                feature_dict = (
-                    doc.get("features", {}).get(table.name, {})
-                    if doc else {}
-                )
-
-                for feature in requested_features:
-                    raw_feature_columns[feature].append(
-                        feature_dict.get(feature)
-                    )
-
-            # Step 2: Convert per feature
-            # You need feature types. We can get these from the table!
-            #   The following will map feature.name to its value type. This is across columns
-            #   features_raw contains the columns for a single row (entity)
-            #   feature_type_map is done outside the entity loop
-            feature_type_map = {
-                feature.name: feature.dtype.to_value_type()
-                for feature in table.features
-            }
-            proto_feature_columns = {}
-            for feature_name, raw_values in raw_feature_columns.items():
-                proto_feature_columns[feature_name] = python_values_to_proto_values(
-                    raw_values,
-                    feature_type=feature_type_map[feature_name],
-                )
-
-            # Step 3: Reassemble row-wise
-            results = []
-
-            for i, entity_id in enumerate(ids):
-                doc = docs.get(entity_id)
-
-                if doc is None:
-                    results.append((None, None))
-                    continue
-
-                ts = doc.get("event_timestamps", {}).get(table.name)
-
-                row_features = {
-                    feature_name: proto_feature_columns[feature_name][i]
-                    for feature_name in requested_features
-                }
-
-                results.append((ts, row_features))
-
-        return results
-        """
-    # ------------------------------------------------------------------
-
     def update(
         self,
         config: RepoConfig,

diff --git a/...hon/feast/infra/online_stores/contrib/mongodb_online_store/tests/test_online_retrieval.py b/...hon/feast/infra/online_stores/contrib/mongodb_online_store/tests/test_online_retrieval.py
@@ -1,25 +1,16 @@
 import os
-import platform
-import random
-import sqlite3
-import sys
 import time
-from typing import Any
 
-import numpy as np
 import pandas as pd
 import pytest
-import sqlite_vec
 from pandas.testing import assert_frame_equal
 
 from feast import FeatureStore, RepoConfig
 from feast.errors import FeatureViewNotFoundException
 from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
-from feast.protos.feast.types.Value_pb2 import FloatList as FloatListProto
 from feast.protos.feast.types.Value_pb2 import Value as ValueProto
 from feast.repo_config import RegistryConfig
 from feast.torch_wrapper import get_torch
-from feast.types import ValueType
 from feast.utils import _utc_now
 from tests.integration.feature_repos.universal.feature_views import TAGS
 from tests.utils.cli_repo_creator import CliRunner, get_example_repo

diff --git a/...python/feast/infra/online_stores/contrib/mongodb_online_store/tests/test_online_writes.py b/...python/feast/infra/online_stores/contrib/mongodb_online_store/tests/test_online_writes.py
@@ -36,7 +36,6 @@
 from feast.infra.online_stores.contrib.mongodb_online_store.mongodb import (
     MongoDBOnlineStoreConfig,
 )
-from feast.infra.online_stores.sqlite import SqliteOnlineStoreConfig
 from feast.on_demand_feature_view import on_demand_feature_view
 from feast.types import Array, Float32, Float64, Int64, PdfBytes, String, ValueType
 from tests.utils.test_wrappers import check_warnings