Data source writer ignored parameters, fixed

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
feast-dev · ntkathole · Mar 14, 2026 · Feb 24, 2026 · Feb 24, 2026 · Feb 24, 2026
commit 07e6969dcd2e30d9a706e784f5c40d79d6031600
@@ -104,7 +104,17 @@ def _write_data_source(
         allow_overwrite: bool = False,
     ):
         assert isinstance(data_source, OracleSource)
-        con.insert(table_name=data_source.table_ref, obj=table.to_pandas())
+        table_ref = data_source.table_ref
+
+        if mode == "overwrite":
+            if not allow_overwrite:
+                raise ValueError(
+                    f"Table '{table_ref}' already exists. "
+                    f"Set allow_overwrite=True to truncate and replace data."
+                )
+            con.raw_sql(f"TRUNCATE TABLE {table_ref}")
+
+        con.insert(table_name=table_ref, obj=table.to_pandas())
 
     return _write_data_source