Skip to content

fix: Add https readiness check for rest-registry tests #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Feb 23, 2026
Merged

fix: Add https readiness check for rest-registry tests #5978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions sdk/python/tests/integration/registration/rest_api/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import time
from pathlib import Path

import pytest
Expand Down Expand Up @@ -37,6 +38,44 @@ def get(self, endpoint, params=None):
return requests.get(url, params=params, verify=False)


def _wait_for_http_ready(route_url: str, timeout: int = 180, interval: int = 5) -> None:
"""
Poll the HTTP endpoint until it returns a non-502 response.

After Pod/CR readiness is confirmed, the backend behind the ingress may
still be initializing. This helper avoids the race condition where tests
start before the Feast server is ready, causing all requests to return 502.
"""
health_url = f"{route_url}/api/v1/projects"
deadline = time.time() + timeout
last_status = None

print(
f"\n Waiting for HTTP endpoint to become ready (timeout={timeout}s): {health_url}"
)

while time.time() < deadline:
try:
resp = requests.get(health_url, timeout=10, verify=False)
last_status = resp.status_code
if resp.status_code != 502:
print(f" HTTP endpoint is ready (status={resp.status_code})")
return
print(
f" HTTP endpoint returned {resp.status_code}, retrying in {interval}s..."
)
except requests.exceptions.RequestException as exc:
last_status = str(exc)
print(f" HTTP request failed ({exc}), retrying in {interval}s...")

time.sleep(interval)

raise RuntimeError(
f"HTTP endpoint {health_url} did not become ready within {timeout}s "
f"(last status: {last_status})"
)


@pytest.fixture(scope="session")
def feast_rest_client():
# Load kubeconfig and initialize Kubernetes client
Expand Down Expand Up @@ -142,6 +181,11 @@ def feast_rest_client():
if not route_url:
raise RuntimeError("Route URL could not be fetched.")

# Wait for the HTTP endpoint to become ready before running tests.
# Pod/CR readiness does not guarantee the backend is serving traffic;
# the ingress may return 502 while the Feast server is still starting.
_wait_for_http_ready(route_url)

print(f"\n Connected to Feast REST at: {route_url}")
yield FeastRestClient(route_url)

Expand Down
Loading