Skip to content

Create project if not exists on applyFeatureSet - #596

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
Joostrothweiler:create-project-on-apply
Apr 3, 2020
Merged

Create project if not exists on applyFeatureSet#596
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
Joostrothweiler:create-project-on-apply

Conversation

@Joostrothweiler

@Joostrothweiler Joostrothweiler commented Apr 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Allow create_project to rerun safely #453. Instead of having to run create_project before apply, the apply method can create the project if it does not already exist.
Which issue(s) this PR fixes:

Fixes #453

Does this PR introduce a user-facing change?:

When applying a featureSet to a project that does not yet exist, Feast create the project on apply.

@feast-ci-bot

feast-ci-bot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

Hi @Joostrothweiler. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Joostrothweiler Joostrothweiler mentioned this pull request Apr 2, 2020
Closed
@Joostrothweiler

Joostrothweiler commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

/assign @thirteen37

@Joostrothweiler Joostrothweiler changed the title Create project on apply Create project on applyFeatureSet Apr 2, 2020
@Joostrothweiler Joostrothweiler changed the title Create project on applyFeatureSet Create project if not exists on applyFeatureSet Apr 2, 2020
@woop

woop commented Apr 3, 2020

Copy link
Copy Markdown
Member

/ok-to-test

@feast-ci-bot

feast-ci-bot commented Apr 3, 2020

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joostrothweiler, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Apr 3, 2020

Copy link
Copy Markdown
Member

Awesome, thanks @Joostrothweiler!

@woop

woop commented Apr 3, 2020

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot
feast-ci-bot merged commit 49b7cd1 into feast-dev:master Apr 3, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Apr 15, 2020
@Joostrothweiler @woop @khorshuheng
Create project if not exists on applyFeatureSet (feast-dev#596)
0a4cd0b 
* Create project if not exists on apply

* Update comments to reflect new situation

* Fixed typo in comment

Co-authored-by: Joost Rothweiler <=>
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
@khorshuheng khorshuheng mentioned this pull request Apr 15, 2020
Merged
khorshuheng pushed a commit that referenced this pull request Apr 15, 2020
@Joostrothweiler @woop @khorshuheng
Create project if not exists on applyFeatureSet (#596)
0202dfb 
* Create project if not exists on apply

* Update comments to reflect new situation

* Fixed typo in comment

Co-authored-by: Joost Rothweiler <=>
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes
@pradithya pradithya Awaiting requested review from pradithya
@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@thirteen37 thirteen37

@woop woop

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow create_project to rerun safely

4 participants

@Joostrothweiler @feast-ci-bot @woop @thirteen37