Skip to content

fix: Correct typo 'occured' to 'occurred' #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecaptain789 wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −2
Open

fix: Correct typo 'occured' to 'occurred' #5950

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1980d1
fix: correct typo 'occured' to 'occurred' in variable name
thecaptain789 Feb 7, 2026
07a9a4e
Merge branch 'master' into fix/typo-occurred
shuchu Feb 15, 2026
b01b349
Merge branch 'master' into fix/typo-occurred
shuchu Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/python/tests/unit/infra/test_dependency_conflicts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ def test_install_kserve_with_feast(self):

# Assertions
assert exit_code == 0
conflict_occured = "dependency conflicts" in err and "ERROR" not in err
assert not conflict_occured, "Dependency conflict detected during installation"
conflict_occurred = "dependency conflicts" in err and "ERROR" not in err
assert not conflict_occurred, "Dependency conflict detected during installation"
Comment on lines +31 to +32
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Dependency conflict check condition is logically inverted, making the test ineffective

The condition on line 31 uses and to combine two checks, but this means actual pip dependency conflicts are never caught.

Root Cause

When pip detects dependency conflicts but still succeeds (exit code 0), it outputs to stderr a message like:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. Running pip check may reveal dependency conflicts.

The current condition is:

conflict_occurred = "dependency conflicts" in err and "ERROR" not in err

Since pip's conflict message contains BOTH "dependency conflicts" AND "ERROR", the evaluation is:

  • "dependency conflicts" in err → True
  • "ERROR" not in err → False
  • True and False → False

So conflict_occurred is False, and assert not False passes. The test will never detect actual dependency conflicts from pip.

The condition should likely be:

conflict_occurred = "dependency conflicts" in err or "ERROR" in err

or simply:

conflict_occurred = "dependency conflicts" in err

Impact: The test is meant to catch dependency conflicts between Feast and KServe, but it will always pass regardless of whether conflicts exist, defeating its purpose.

Suggested change
conflict_occurred = "dependency conflicts" in err and "ERROR" not in err
assert not conflict_occurred, "Dependency conflict detected during installation"
conflict_occurred = "dependency conflicts" in err
assert not conflict_occurred, "Dependency conflict detected during installation"
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Loading