Skip to content

feat: Batch_engine config injection in feature_store.yaml through operator #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 3 commits into from
Feb 10, 2026
Merged

feat: Batch_engine config injection in feature_store.yaml through operator #5938

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7159e6f
feat: batch_engine config injection in feature_store.yaml through ope…
aniketpalu Feb 3, 2026
185617c
Updated repo_config test with added parameter for getServiceRepoConfi…
aniketpalu Feb 5, 2026
f70f0af
Removed image tag change from ustomization.yaml
aniketpalu Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated repo_config test with added parameter for getServiceRepoConfi… 
…g func

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu @ntkathole
aniketpalu authored and ntkathole committed Feb 10, 2026
commit 185617c9fe0bb49cc39cb6ededcb70d858126e09
24 changes: 14 additions & 10 deletions infra/feast-operator/internal/controller/services/repo_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ var _ = Describe("Repo Config", func() {
Path: EphemeralPath + "/" + DefaultOnlineStorePath,
}

repoConfig, err := getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret)
repoConfig, err := getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(NoAuthAuthType))
Expect(repoConfig.OfflineStore).To(Equal(emptyOfflineStoreConfig))
Expand Down Expand Up @@ -74,7 +74,7 @@ var _ = Describe("Repo Config", func() {
Path: testPath,
}

repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(NoAuthAuthType))
Expect(repoConfig.OfflineStore).To(Equal(emptyOfflineStoreConfig))
Expand All @@ -96,7 +96,7 @@ var _ = Describe("Repo Config", func() {
Expect(appliedServices.OnlineStore).NotTo(BeNil())
Expect(appliedServices.Registry.Local).NotTo(BeNil())

repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.OfflineStore).To(Equal(defaultOfflineStoreConfig))
Expect(repoConfig.AuthzConfig.Type).To(Equal(NoAuthAuthType))
Expand All @@ -115,7 +115,7 @@ var _ = Describe("Repo Config", func() {
},
}
ApplyDefaultsToStatus(featureStore)
repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(NoAuthAuthType))
Expect(repoConfig.OfflineStore).To(Equal(emptyOfflineStoreConfig))
Expand Down Expand Up @@ -163,7 +163,7 @@ var _ = Describe("Repo Config", func() {
Path: "/data/online.db",
}

repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, emptyMockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(NoAuthAuthType))
Expect(repoConfig.OfflineStore).To(Equal(expectedOfflineConfig))
Expand All @@ -188,7 +188,7 @@ var _ = Describe("Repo Config", func() {
Type: "dask",
}

repoConfig, err = getServiceRepoConfig(featureStore, mockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, mockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(KubernetesAuthType))
Expect(repoConfig.OfflineStore).To(Equal(expectedOfflineConfig))
Expand All @@ -211,7 +211,7 @@ var _ = Describe("Repo Config", func() {
string(OidcClientSecret): "client-secret",
string(OidcUsername): "username",
string(OidcPassword): "password"})
repoConfig, err = getServiceRepoConfig(featureStore, secretExtractionFunc)
repoConfig, err = getServiceRepoConfig(featureStore, secretExtractionFunc, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
Expect(repoConfig.AuthzConfig.Type).To(Equal(OidcAuthType))
Expect(repoConfig.AuthzConfig.OidcParameters).To(HaveLen(5))
Expand Down Expand Up @@ -275,7 +275,7 @@ var _ = Describe("Repo Config", func() {
featureStore.Spec.Services.OfflineStore.Persistence.FilePersistence = nil
featureStore.Spec.Services.OnlineStore.Persistence.FilePersistence = nil
featureStore.Spec.Services.Registry.Local.Persistence.FilePersistence = nil
repoConfig, err = getServiceRepoConfig(featureStore, mockExtractConfigFromSecret)
repoConfig, err = getServiceRepoConfig(featureStore, mockExtractConfigFromSecret, emptyMockExtractConfigFromConfigMap)
Expect(err).NotTo(HaveOccurred())
newMap := CopyMap(parameterMap)
port := parameterMap["port"].(int)
Expand Down Expand Up @@ -316,7 +316,7 @@ var _ = Describe("Repo Config", func() {
string(OidcClientSecret): "client-secret",
string(OidcUsername): "username",
string(OidcPassword): "password"})
_, err := getServiceRepoConfig(featureStore, secretExtractionFunc)
_, err := getServiceRepoConfig(featureStore, secretExtractionFunc, emptyMockExtractConfigFromConfigMap)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("missing OIDC secret"))
_, err = getClientRepoConfig(featureStore, secretExtractionFunc, nil)
Expand All @@ -338,7 +338,7 @@ var _ = Describe("Repo Config", func() {
string(OidcClientId): "client-id",
string(OidcUsername): "username",
string(OidcPassword): "password"})
_, err = getServiceRepoConfig(featureStore, secretExtractionFunc)
_, err = getServiceRepoConfig(featureStore, secretExtractionFunc, emptyMockExtractConfigFromConfigMap)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("missing OIDC secret"))
_, err = getClientRepoConfig(featureStore, secretExtractionFunc, nil)
Expand Down Expand Up @@ -380,6 +380,10 @@ func emptyMockExtractConfigFromSecret(storeType string, secretRef string, secret
return map[string]interface{}{}, nil
}

func emptyMockExtractConfigFromConfigMap(configMapRef string, configMapKey string) (map[string]interface{}, error) {
return map[string]interface{}{}, nil
}

func mockExtractConfigFromSecret(storeType string, secretRef string, secretKeyName string) (map[string]interface{}, error) {
return createParameterMap(), nil
}
Expand Down