Skip to content

fix: Fix linting and formatting issues #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 3 commits into from
Jan 26, 2026
Merged

fix: Fix linting and formatting issues #5907

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea4ea80
fix: Fix code formatting in type_map.py
franciscojavierarceo Jan 26, 2026
beb10c2
fix: Fix SQLite I/O error in OnDemandPythonTransformation tests
franciscojavierarceo Jan 26, 2026
f74580d
fix: Apply ruff formatting to test file
franciscojavierarceo Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Apply ruff formatting to test file
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jan 26, 2026
commit f74580d7f72564a9d68c8b32ba5ced15c895758b
19 changes: 6 additions & 13 deletions sdk/python/tests/unit/test_on_demand_python_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,9 @@ def setUp(self):
start_date = end_date - timedelta(days=15)

driver_entities = [1001, 1002, 1003, 1004, 1005]
driver_df = create_driver_hourly_stats_df(
driver_entities, start_date, end_date
)
driver_df = create_driver_hourly_stats_df(driver_entities, start_date, end_date)
driver_stats_path = os.path.join(data_dir, "driver_stats.parquet")
driver_df.to_parquet(
path=driver_stats_path, allow_truncated_timestamps=True
)
driver_df.to_parquet(path=driver_stats_path, allow_truncated_timestamps=True)

driver = Entity(
name="driver", join_keys=["driver_id"], value_type=ValueType.INT64
Expand Down Expand Up @@ -123,9 +119,7 @@ def setUp(self):
)
def pandas_view(inputs: pd.DataFrame) -> pd.DataFrame:
df = pd.DataFrame()
df["conv_rate_plus_acc_pandas"] = (
inputs["conv_rate"] + inputs["acc_rate"]
)
df["conv_rate_plus_acc_pandas"] = inputs["conv_rate"] + inputs["acc_rate"]
return df

@on_demand_feature_view(
Expand All @@ -136,9 +130,7 @@ def pandas_view(inputs: pd.DataFrame) -> pd.DataFrame:
def python_view(inputs: dict[str, Any]) -> dict[str, Any]:
output: dict[str, Any] = {
"conv_rate_plus_acc_python": conv_rate + acc_rate
for conv_rate, acc_rate in zip(
inputs["conv_rate"], inputs["acc_rate"]
)
for conv_rate, acc_rate in zip(inputs["conv_rate"], inputs["acc_rate"])
}
return output

Expand Down Expand Up @@ -245,7 +237,8 @@ def python_stored_writes_feature_view(

def tearDown(self):
import shutil
if hasattr(self, 'data_dir'):

if hasattr(self, "data_dir"):
shutil.rmtree(self.data_dir, ignore_errors=True)

def test_setup(self):
Expand Down
Loading