Skip to content

feat: Add integration tests for dbt import #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Feb 9, 2026
Merged

feat: Add integration tests for dbt import #5899

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5a3f8
Add comprehensive integration tests for dbt import feature
YassinNouh21 Feb 7, 2026
e5209dd
Add ok-to-test label check to dbt integration workflow
YassinNouh21 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add ok-to-test label check to dbt integration workflow 
- Add PR trigger types (opened, synchronize, labeled)
- Add label check condition requiring ok-to-test/approved/lgtm
- Prevents resource spin-up for every PR

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
  • Loading branch information
@YassinNouh21
YassinNouh21 committed Feb 9, 2026
commit e5209dd311fa1282b2497ddee96a097e8e06650a
8 changes: 8 additions & 0 deletions .github/workflows/dbt-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: dbt-integration-tests
# Run dbt integration tests on PRs
on:
pull_request:
types:
- opened
- synchronize
- labeled
paths:
- 'sdk/python/feast/dbt/**'
- 'sdk/python/tests/integration/dbt/**'
Expand All @@ -11,6 +15,10 @@ on:

jobs:
dbt-integration-test:
if:
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
runs-on: ubuntu-latest
Copy link
Copy Markdown
Member

@ntkathole ntkathole Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a check for ok-to-test label so that resources don't get spin up for every PR raised, similar to other integration tests pattern
https://github.com/feast-dev/feast/blob/master/.github/workflows/pr_local_integration_tests.yml#L13

strategy:
matrix:
Expand Down
Loading