Skip to content

feat: Add Set as feature type #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 11 commits into from
Jan 29, 2026
Merged

feat: Add Set as feature type #5888

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
821b1f2
Add Set types to Feast type system
franciscojavierarceo Jan 27, 2026
8ba622e
Fix Milvus integration for Set types
franciscojavierarceo Jan 27, 2026
a56b774
Fix item_id type mismatch in milvus test
franciscojavierarceo Jan 27, 2026
325edb7
Apply ruff formatting
franciscojavierarceo Jan 27, 2026
947bfb7
Merge branch 'master' into copilot/add-set-as-feature-type
franciscojavierarceo Jan 27, 2026
191782b
refactor: Extract Set type conversion to separate function
franciscojavierarceo Jan 27, 2026
45251de
Apply ruff formatting to refactored code
franciscojavierarceo Jan 27, 2026
2ad1eec
Delete test_registry
franciscojavierarceo Jan 28, 2026
4f7128a
Merge branch 'master' into copilot/add-set-as-feature-type
franciscojavierarceo Jan 28, 2026
5e87fc9
Merge branch 'master' into copilot/add-set-as-feature-type
franciscojavierarceo Jan 28, 2026
4a45b75
Merge branch 'master' into copilot/add-set-as-feature-type
franciscojavierarceo Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix item_id type mismatch in milvus test 
The test was providing string values for item_id field which is
defined as Int64 in the schema, causing protobuf serialization
issues that could manifest as Unicode decode errors.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
  • Loading branch information
@franciscojavierarceo @claude
franciscojavierarceo and claude committed Jan 27, 2026
commit a56b774c1fdc1a8d8c918db67714c422a2ba0690
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/online_store/test_online_retrieval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ def test_milvus_lite_retrieve_online_documents_v2() -> None:
)
documents_df = pd.DataFrame(
{
"item_id": [str(i) for i in range(n)],
Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bug

"item_id": [i for i in range(n)],
"author_id": [f"author_{i}" for i in range(n)],
"vector": [
np.random.random(
Expand Down