Skip to content

fix: Timestamp formatting and lakehouse-type connector for trino_offline_store. #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Jan 16, 2026
Merged

fix: Timestamp formatting and lakehouse-type connector for trino_offline_store. #5846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583a34d
fix: Timestamp formatting and lakehouse-type connector for trino_offl…
soliverr Jan 13, 2026
f389ebf
Merge branch 'master' into master
franciscojavierarceo Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Timestamp formatting and lakehouse-type connector for trino_offl… 
…ine_store.

Signed-off-by: Sergey Kryazhevskikh <soliverr@gmail.com>
  • Loading branch information
@soliverr
soliverr committed Jan 15, 2026
commit 583a34d4fcae25020a8b46fc8aa18b08dc07b405
1 change: 1 addition & 0 deletions sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"oracle",
"redshift",
"memsql",
"lakehouse",
}

CREATE_SCHEMA_QUERY_TEMPLATE = """
Expand Down
9 changes: 7 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,16 @@ def pull_all_from_table_or_query(
)

timestamp_filter = get_timestamp_filter_sql(
start_date, end_date, timestamp_field, quote_fields=False
start_date,
end_date,
timestamp_field,
quote_fields=False,
cast_style="timestamp",
date_time_separator=" ",
)
query = f"""
SELECT {field_string}
FROM {from_expression}
FROM ( {from_expression} )
WHERE {timestamp_filter}
"""
return TrinoRetrievalJob(
Expand Down
Loading