Skip to content

chore: Refactor some unit tests into integration tests #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Jan 6, 2026
Merged

chore: Refactor some unit tests into integration tests #5820

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d292310
chore: Refactor some unit tests into integration tests
franciscojavierarceo Jan 6, 2026
d3a66fe
chore: Refactor some unit tests into integration tests
franciscojavierarceo Jan 6, 2026
60484bc
rename TestConfig
franciscojavierarceo Jan 6, 2026
021811e
rename TestConfig
franciscojavierarceo Jan 6, 2026
533110c
add integration flag
franciscojavierarceo Jan 6, 2026
29f8280
update paths
franciscojavierarceo Jan 6, 2026
95f5098
update paths
franciscojavierarceo Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename TestConfig 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
  • Loading branch information
@franciscojavierarceo
franciscojavierarceo committed Jan 6, 2026
commit 021811ef45add817c672e747fdadbd2cb72c5f9d
17 changes: 13 additions & 4 deletions sdk/python/tests/integration/registration/rest_api/test_registry_rest_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,10 @@ def test_list_feature_services(self, feast_rest_client):
data = APITestHelpers.validate_response_success(response)

feature_services = data.get("featureServices", [])
assert len(feature_services) == RegistryTestConfig.DRIVER_RANKING_FEATURE_SERVICES_COUNT
assert (
len(feature_services)
== RegistryTestConfig.DRIVER_RANKING_FEATURE_SERVICES_COUNT
)

# Validate batch sources in features
for fs in feature_services:
Expand Down Expand Up @@ -319,7 +322,8 @@ def test_list_feature_views(self, feast_rest_client):
data = APITestHelpers.validate_response_success(response)

assert (
len(data["featureViews"]) == RegistryTestConfig.CREDIT_SCORING_FEATURE_VIEWS_COUNT
len(data["featureViews"])
== RegistryTestConfig.CREDIT_SCORING_FEATURE_VIEWS_COUNT
)
APITestHelpers.validate_pagination(
data, RegistryTestConfig.CREDIT_SCORING_FEATURE_VIEWS_COUNT
Expand Down Expand Up @@ -404,7 +408,10 @@ def test_features_all(self, feast_rest_client):
# Project Tests
@pytest.mark.parametrize(
"project_name",
[RegistryTestConfig.CREDIT_SCORING_PROJECT, RegistryTestConfig.DRIVER_RANKING_PROJECT],
[
RegistryTestConfig.CREDIT_SCORING_PROJECT,
RegistryTestConfig.DRIVER_RANKING_PROJECT,
],
)
def test_get_project_by_name(self, feast_rest_client, project_name):
"""Test getting a project by name."""
Expand Down Expand Up @@ -560,7 +567,9 @@ def test_saved_datasets_endpoints(self, feast_rest_client, endpoint, key):
)

# Validate pagination
APITestHelpers.validate_pagination(data, RegistryTestConfig.SAVED_DATASETS_COUNT)
APITestHelpers.validate_pagination(
data, RegistryTestConfig.SAVED_DATASETS_COUNT
)
if endpoint == "/saved_datasets/all":
assert data["pagination"]["page"] == 1
assert data["pagination"]["limit"] == 50
Expand Down
Loading