Skip to content

fix: Add get_table_query_string_with_alias() for PostgreSQL subquery aliasing #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Jan 10, 2026
Merged

fix: Add get_table_query_string_with_alias() for PostgreSQL subquery aliasing #5811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
994a632
fix: Add get_table_query_string_with_alias() for PostgreSQL subquery …
YassinNouh21 Jan 4, 2026
8f81119
style: Fix ruff 0.14.10 formatting for test file
YassinNouh21 Jan 4, 2026
f3eb357
fix: Remove doctest markers from example to avoid test failures
YassinNouh21 Jan 4, 2026
874852b
Merge branch 'master' into fix/postgresql-entity-sql-alias-5605
franciscojavierarceo Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: Fix ruff 0.14.10 formatting for test file 
Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
  • Loading branch information
@YassinNouh21
YassinNouh21 committed Jan 4, 2026
commit 8f81119c489d2b38fd16a98383261d911d43463d
6 changes: 3 additions & 3 deletions sdk/python/tests/unit/infra/offline_stores/contrib/postgres_offline_store/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,9 +1057,9 @@ def test_sql_query_without_alias_fails_in_postgres(self):
# This produces: SELECT id, ts FROM (SELECT id, ts FROM raw_data)
# which is invalid in PostgreSQL (subquery needs alias)
# sqlglot is lenient and may parse it, but PostgreSQL would reject it
assert (
"AS" not in entity_sql_without_alias
), "get_table_query_string() should not add alias"
assert "AS" not in entity_sql_without_alias, (
"get_table_query_string() should not add alias"
)

# Using the new method (with alias) produces valid SQL
entity_sql_with_alias = (
Expand Down
Loading