Skip to content

fix(redis): Preserve millisecond timestamp precision for Redis online store #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Jan 6, 2026
Merged

fix(redis): Preserve millisecond timestamp precision for Redis online store #5807

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f26c62
Update redis.py
jatin5251 Jan 1, 2026
828da5b
Update redis.py
jatin5251 Jan 1, 2026
a7dca65
Update redis.py
jatin5251 Jan 1, 2026
547ca7d
Merge branch 'master' into redis-ms-timestamp
jatin5251 Jan 2, 2026
2fded63
Merge branch 'master' into redis-ms-timestamp
jatin5251 Jan 6, 2026
ea3be27
Update redis.py
jatin5251 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update redis.py 
fix: Remove whitespace on blank lines (W293)

Signed-off-by: Jatin Kumar <jatink.5251@gmail.com>
  • Loading branch information
@jatin5251
jatin5251 authored Jan 6, 2026
commit ea3be2798dbf3e0dc7b6e9b6343e56e09d32b936
3 changes: 0 additions & 3 deletions sdk/python/feast/infra/online_stores/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,11 @@ def online_write_batch(
):
# Convert incoming timestamp to millisecond-aware datetime
aware_ts = utils.make_tzaware(timestamp)

# Build protobuf timestamp with nanos
ts = Timestamp()
ts.FromDatetime(aware_ts)
# New timestamp in nanoseconds
new_total_nanos = ts.seconds * 1_000_000_000 + ts.nanos

# Compare against existing timestamp (nanosecond precision)
if prev_event_time:
prev_ts = Timestamp()
Expand All @@ -323,7 +321,6 @@ def online_write_batch(
if progress:
progress(1)
continue

# Store full timestamp (seconds + nanos)
entity_hset = {ts_key: ts.SerializeToString()}

Expand Down
Loading