Skip to content

fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 6 commits into from
Nov 3, 2025
Merged

fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore #5703

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8a8ab6
Added start_date & end_date range for historical data retrieval from …
aniketpalu Oct 21, 2025
d6bb773
Minor linting & reformatting changes
aniketpalu Oct 21, 2025
0e17fdf
Fixed minor issue of empty df with only key as column being trated as…
aniketpalu Oct 28, 2025
434ab75
Merge branch 'master' into RHOAIENG-32904
aniketpalu Nov 1, 2025
0d52d17
Removed unnecessary logic to create mock df
aniketpalu Nov 3, 2025
4bf7de7
Minor linting & formatting changes
aniketpalu Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added start_date & end_date range for historical data retrieval from … 
…RemoteOfflineStore

Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu @ntkathole
aniketpalu authored and ntkathole committed Oct 23, 2025
commit b8a8ab68077a2d3c25b35c49649fde8d97b66dfa
10 changes: 10 additions & 0 deletions sdk/python/feast/infra/offline_stores/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def get_historical_features(
registry: BaseRegistry,
project: str,
full_feature_names: bool = False,
**kwargs,
) -> RemoteRetrievalJob:
assert isinstance(config.offline_store, RemoteOfflineStoreConfig)

Expand All @@ -218,6 +219,15 @@ def get_historical_features(
"full_feature_names": full_feature_names,
"name_aliases": name_aliases,
}

# Extract and serialize start_date/end_date for remote transmission
start_date = kwargs.get("start_date", None)
end_date = kwargs.get("end_date", None)

if start_date is not None:
api_parameters["start_date"] = start_date.isoformat()
if end_date is not None:
api_parameters["end_date"] = end_date.isoformat()

return RemoteRetrievalJob(
client=client,
Expand Down
12 changes: 12 additions & 0 deletions sdk/python/feast/offline_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,17 @@ def get_historical_features(self, command: dict, key: Optional[str] = None):
resource=feature_view, actions=[AuthzedAction.READ_OFFLINE]
)

# Extract and deserialize start_date/end_date if present
kwargs = {}
if "start_date" in command and command["start_date"] is not None:
kwargs["start_date"] = utils.make_tzaware(
datetime.fromisoformat(command["start_date"])
)
if "end_date" in command and command["end_date"] is not None:
kwargs["end_date"] = utils.make_tzaware(
datetime.fromisoformat(command["end_date"])
)

retJob = self.offline_store.get_historical_features(
config=self.store.config,
feature_views=feature_views,
Expand All @@ -457,6 +468,7 @@ def get_historical_features(self, command: dict, key: Optional[str] = None):
registry=self.store.registry,
project=project,
full_feature_names=full_feature_names,
**kwargs,
)

return retJob
Expand Down