Skip to content

feat: Add annotations to cronjob CRDs #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Oct 29, 2025
Merged

feat: Add annotations to cronjob CRDs #5701

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d18e38
feat: Add annotations to cronjob CRDs
FredericKayser Oct 28, 2025
6032da7
Implement handling of annotations
FredericKayser Oct 28, 2025
7ca033a
Add auto-generated files
FredericKayser Oct 28, 2025
f960b54
Implement changes from review
FredericKayser Oct 28, 2025
432aab3
Implement changes from review
FredericKayser Oct 28, 2025
c2b4e92
Merge branch 'master' into feat/add-annotations-to-cronjob-crds
franciscojavierarceo Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement changes from review 
Signed-off-by: Frederic Kayser <frederic@frederic-kayser.de>
  • Loading branch information
@FredericKayser
FredericKayser committed Oct 29, 2025
commit 432aab3981271e97162dc139c9adf39d567747b1
8 changes: 2 additions & 6 deletions infra/feast-operator/internal/controller/services/cronjob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,9 @@ func (feast *FeastServices) setCronJob(cronJob *batchv1.CronJob) error {
appliedCronJob := feast.Handler.FeatureStore.Status.Applied.CronJob
cronJob.Labels = feast.getFeastTypeLabels(CronJobFeastType)
if appliedCronJob.Annotations != nil {
if cronJob.Annotations == nil {
cronJob.Annotations = make(map[string]string)
}
cronJob.Annotations = make(map[string]string, len(appliedCronJob.Annotations))
for k, v := range appliedCronJob.Annotations {
if _, exists := cronJob.Annotations[k]; !exists {
cronJob.Annotations[k] = v
}
cronJob.Annotations[k] = v
Comment thread
FredericKayser marked this conversation as resolved.
}
}
cronJob.Spec = batchv1.CronJobSpec{
Expand Down
Loading