Skip to content

fix: Improve trino to feast type mapping with (real,varchar,timestamp,decimal) #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Oct 29, 2025
Merged

fix: Improve trino to feast type mapping with (real,varchar,timestamp,decimal) #5691

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a1e8b8
fix: improve trino to feast type mapping with (real,varchar,timestamp…
Oct 24, 2025
531a74c
Remove whitespace from blank line
Oct 24, 2025
a1bcd34
Merge branch 'master' into fix/trino_to_feast_value_type
franciscojavierarceo Oct 29, 2025
e4f1cd7
Merge branch 'master' into fix/trino_to_feast_value_type
franciscojavierarceo Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: improve trino to feast type mapping with (real,varchar,timestamp… 
…,decimal)

Signed-off-by: fengxiaochuan <fengxiaochuan@corp.netease.com>
  • Loading branch information
@ntkathole
fengxiaochuan authored and ntkathole committed Oct 26, 2025
commit 7a1e8b811a6100c1883a68ce17dbd69feed1b648
28 changes: 26 additions & 2 deletions sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,37 @@ def trino_to_feast_value_type(trino_type_as_str: str) -> ValueType:
"integer": ValueType.INT32,
"bigint": ValueType.INT64,
"double": ValueType.DOUBLE,
"decimal": ValueType.FLOAT,
"decimal32": ValueType.FLOAT,
"decimal64": ValueType.DOUBLE,
"timestamp": ValueType.UNIX_TIMESTAMP,
"char": ValueType.STRING,
"varchar": ValueType.STRING,
"boolean": ValueType.BOOL,
"real": ValueType.FLOAT,
}
return type_map[trino_type_as_str.lower()]
_trino_type_as_str: str = trino_type_as_str
trino_type_as_str = trino_type_as_str.lower()

if trino_type_as_str.startswith("decimal"):
search_precision = re.search(
Comment thread
shuchu marked this conversation as resolved.
r"^decimal\((\d+)(?>,\s?\d+)?\)$", trino_type_as_str
)
if search_precision:
precision = int(search_precision.group(1))
if precision > 32:
trino_type_as_str = "decimal64"
else:
trino_type_as_str = "decimal32"

elif trino_type_as_str.startswith("timestamp"):
trino_type_as_str = "timestamp"

elif trino_type_as_str.startswith("varchar"):
trino_type_as_str = "varchar"

if trino_type_as_str not in type_map:
raise ValueError(f"Trino type not supported by feast {_trino_type_as_str}")
return type_map[trino_type_as_str]


def pa_to_trino_value_type(pa_type_as_str: str) -> str:
Expand Down