Skip to content

fix: Date wise remote offline store historical data retrieval #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Oct 23, 2025
Merged

fix: Date wise remote offline store historical data retrieval #5686

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a8ab6
Added start_date & end_date range for historical data retrieval from …
aniketpalu Oct 21, 2025
d6bb773
Minor linting & reformatting changes
aniketpalu Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor linting & reformatting changes 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu @ntkathole
aniketpalu authored and ntkathole committed Oct 23, 2025
commit d6bb7730c7be75761585373fbe3eee2c6991860a
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def get_historical_features(
"full_feature_names": full_feature_names,
"name_aliases": name_aliases,
}

# Extract and serialize start_date/end_date for remote transmission
start_date = kwargs.get("start_date", None)
end_date = kwargs.get("end_date", None)
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/offline_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ def get_historical_features(self, command: dict, key: Optional[str] = None):
resource=feature_view, actions=[AuthzedAction.READ_OFFLINE]
)

# Extract and deserialize start_date/end_date if present
# Extract and deserialize start_date/end_date if present
kwargs = {}
if "start_date" in command and command["start_date"] is not None:
kwargs["start_date"] = utils.make_tzaware(
Expand All @@ -459,7 +459,7 @@ def get_historical_features(self, command: dict, key: Optional[str] = None):
kwargs["end_date"] = utils.make_tzaware(
datetime.fromisoformat(command["end_date"])
)

retJob = self.offline_store.get_historical_features(
config=self.store.config,
feature_views=feature_views,
Expand Down
Loading