Skip to content

feat: Add OTEL based observability to the Go Feature Server #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuchu merged 7 commits into from
Oct 24, 2025
Merged

feat: Add OTEL based observability to the Go Feature Server #5685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0cd3bb
feat: Add OTEL based observability to Go feature server.
shuchu Oct 16, 2025
df6fcc3
fix: Fix the traces export issue.
shuchu Oct 21, 2025
82c5d26
fix: Remove the unnecessary coded exporter URL.
shuchu Oct 22, 2025
9973374
Merge branch 'feast-dev:master' into feat/issue-4821a
shuchu Oct 22, 2025
fc4107a
fix: Fix typos in README.
shuchu Oct 22, 2025
2075335
fix: Improve the code by following the Copilot AI's suggestions.
shuchu Oct 22, 2025
f8ae342
Merge branch 'master' into feat/issue-4821a
shuchu Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Improve the code by following the Copilot AI's suggestions. 
Signed-off-by: Shuchu Han <shuchu.han@gmail.com>
  • Loading branch information
@shuchu
shuchu committed Oct 22, 2025
commit 20753359c0034b71920e5fca92eeb6d53109b12f
4 changes: 2 additions & 2 deletions go/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ exporters:
prometheus:
endpoint: 0.0.0.0:8889
namespace: feast-go
otlp/jarger: # this is a gRPC based exporter. use "otelhttp" for http based exporter.
otlp/jaeger: # this is a gRPC based exporter. use "otelhttp" for http based exporter.
endpoint: jaeger:4317
tls:
insecure: true
Expand All @@ -91,7 +91,7 @@ service:
exporters: [prometheus]
traces:
receivers: [otlp]
exporters: [otlp/jarger]
exporters: [otlp/jaeger]
```
3. Prometheus config.
```yaml
Expand Down
4 changes: 2 additions & 2 deletions go/infra/docker/otel/otel-collector-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exporters:
prometheus:
endpoint: 0.0.0.0:8889
namespace: feast-go
otlp/jarger:
otlp/jaeger:
endpoint: jaeger:4317
tls:
insecure: true
Expand All @@ -28,4 +28,4 @@ service:
exporters: [prometheus]
traces:
receivers: [otlp]
exporters: [otlp/jarger]
exporters: [otlp/jaeger]
1 change: 1 addition & 0 deletions go/internal/feast/onlinestore/redisonlinestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
)

var tracer = otel.Tracer("github.com/feast-dev/feast/go/onlinestore")
Comment thread
shuchu marked this conversation as resolved.

type redisType int

const (
Expand Down
1 change: 0 additions & 1 deletion go/internal/feast/server/grpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (

const feastServerVersion = "0.0.1"


type grpcServingServiceServer struct {
fs *feast.FeatureStore
loggingService *logging.LoggingService
Expand Down
1 change: 0 additions & 1 deletion go/internal/feast/server/http_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ func (s *httpServer) getOnlineFeatures(w http.ResponseWriter, r *http.Request) {
writeJSONError(w, fmt.Errorf("Error decoding JSON request data: %+v", err), http.StatusInternalServerError)
return
}

var featureService *model.FeatureService
if request.FeatureService != nil {
featureService, err = s.fs.GetFeatureService(*request.FeatureService)
Expand Down
2 changes: 1 addition & 1 deletion go/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func main() {
flag.IntVar(&port, "port", port, "Specify a port for the server")
flag.Parse()

// Initial tracer
// Initialize tracer
if OTELTracingEnabled() {
ctx := context.Background()

Expand Down
Loading