Skip to content

feat: Add flexible commandArgs support for complete Feast CLI control #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 2 commits into from
Oct 17, 2025
Merged

feat: Add flexible commandArgs support for complete Feast CLI control #5678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fd3cc
feat: Add flexible commandArgs support for complete Feast CLI control
blaketastic2 Oct 17, 2025
00a4c6f
missed trailing pipe
blaketastic2 Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Add flexible commandArgs support for complete Feast CLI control 
Signed-off-by: Blake <blaketastic2@gmail.com>
  • Loading branch information
@blaketastic2
blaketastic2 committed Oct 17, 2025
commit 58fd3ccdb61dfd378057e4f382bddd95127b3ad6
1 change: 1 addition & 0 deletions infra/charts/feast-feature-server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| affinity | object | `{}` | |
| commandArgs | list | `[]` | Override the default command arguments for complete control over CLI options
| extraEnvs | list | `[]` | Additional environment variables to be set in the container |
| feast_mode | string | `"online"` | Feast supported deployment modes - online (default), offline, ui and registry |
| feature_store_yaml_base64 | string | `""` | [required] a base64 encoded version of feature_store.yaml |
Expand Down
5 changes: 5 additions & 0 deletions infra/charts/feast-feature-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ spec:
{{- toYaml . | nindent 12 }}
{{- end}}
command:
{{- if .Values.commandArgs }}
{{- toYaml .Values.commandArgs | nindent 12 }}
{{- else }}
{{- /* Fallback to legacy behavior for backward compatibility */}}
{{- if eq .Values.feast_mode "offline" }}
- "feast"
- "--log-level"
Expand Down Expand Up @@ -82,6 +86,7 @@ spec:
- "0.0.0.0"
{{- end }}
{{- end }}
{{- end }}
ports:
- name: {{ .Values.feast_mode }}
{{- if eq .Values.feast_mode "offline" }}
Expand Down
18 changes: 18 additions & 0 deletions infra/charts/feast-feature-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,24 @@ feature_store_yaml_base64: ""
# feast_mode -- Feast supported deployment modes - online (default), offline, ui and registry
feast_mode: "online"

# commandArgs -- Override the default command arguments for complete control over CLI options
# If not specified, falls back to legacy behavior based on feast_mode
# Example for UI mode with custom options:
# commandArgs:
# - "feast"
# - "--log-level"
# - "INFO"
# - "ui"
# - "--root_path"
# - "/feast"
# - "--registry_ttl_sec"
# - "300"
# - "-h"
# - "0.0.0.0"
# - "-p"
# - "8888"
commandArgs: []

podAnnotations: {}

podSecurityContext: {}
Expand Down
Loading