Skip to content

feat: Add nodeSelector to service config #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Oct 21, 2025
Merged

feat: Add nodeSelector to service config #5675

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82475a3
add NodeSelector support to config
blaketastic2 Oct 16, 2025
df560e9
Merge branch 'master' into blake/node-selectors
blaketastic2 Oct 17, 2025
722f5c0
Merge branch 'master' into blake/node-selectors
franciscojavierarceo Oct 20, 2025
621ffea
code review updates
blaketastic2 Oct 20, 2025
6a07950
contrived example was actually wrong
blaketastic2 Oct 20, 2025
4ab65ff
removing incorrect docs
blaketastic2 Oct 20, 2025
4fb5c8d
docs are not working with description
blaketastic2 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
contrived example was actually wrong 
Signed-off-by: Blake <blaketastic2@gmail.com>
  • Loading branch information
@blaketastic2
blaketastic2 committed Oct 20, 2025
commit 6a079506e17c6c38e1726918d61c40584e7ecc6e
23 changes: 14 additions & 9 deletions infra/feast-operator/internal/controller/services/services_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,7 @@ var _ = Describe("Registry Service", func() {
Expect(deployment.Spec.Template.Spec.NodeSelector).To(Equal(expectedNodeSelector))
})

It("should merge operator NodeSelector with existing selectors (ops team scenario)", func() {
// Simulate existing node selector from ops team
existingNodeSelector := map[string]string{
"team": "ml",
"environment": "prod",
}

It("should merge operator NodeSelector with existing selectors (mutating webhook scenario)", func() {
// Set NodeSelector for UI service
uiNodeSelector := map[string]string{
"node-type": "ui",
Expand All @@ -302,12 +296,23 @@ var _ = Describe("Registry Service", func() {
applySpecToStatus(featureStore)
feast.refreshFeatureStore(ctx, typeNamespacedName)

// Create deployment and simulate existing node selector
// Create deployment first
deployment := feast.initFeastDeploy()
deployment.Spec.Template.Spec.NodeSelector = existingNodeSelector
Expect(deployment).NotTo(BeNil())
Expect(feast.setDeployment(deployment)).To(Succeed())

// Simulate a mutating webhook or admission controller adding node selectors
// This would happen after the operator creates the pod spec but before scheduling
existingNodeSelector := map[string]string{
"team": "ml",
"environment": "prod",
}
deployment.Spec.Template.Spec.NodeSelector = existingNodeSelector

// Apply the node selector logic again to test merging
// This simulates the operator reconciling and re-applying node selectors
feast.applyNodeSelector(&deployment.Spec.Template.Spec)

// Verify NodeSelector merges existing and operator selectors
expectedNodeSelector := map[string]string{
"team": "ml",
Expand Down
Loading