Skip to content

feat: Add 'featureView' in global search api result for features. #5626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 2 commits into from
Sep 23, 2025
Merged

feat: Add 'featureView' in global search api result for features. #5626

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65d368
Added featureView in the response for search results of features
aniketpalu Sep 22, 2025
d60c8b4
Added tests to check featureView addition in feature search results
aniketpalu Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added tests to check featureView addition in feature search results 
Signed-off-by: Aniket Paluskar <apaluska@redhat.com>
  • Loading branch information
@aniketpalu
aniketpalu committed Sep 23, 2025
commit d60c8b4fa82c959e84802b120dc89f7c3285af1b
9 changes: 9 additions & 0 deletions sdk/python/tests/unit/api/test_search_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,15 @@ def test_search_query_functionality(self, shared_search_responses):
"Expected individual features to appear in search results, but found none"
)

for feature_result in feature_results:
assert "featureView" in feature_result
assert feature_result["featureView"] in [
"user_features",
"product_features",
"transaction_features",
"user_on_demand_features",
]

# Verify we have features that likely come from different feature views
feature_names = {f["name"] for f in feature_results}

Expand Down
Loading