Skip to content

Build push #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 8 commits into from
Jan 13, 2019
Merged

Build push #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b2d427b
Add cloud-build config
Jan 10, 2019
0e2e9ea
Fix images list
Jan 10, 2019
52a9936
Fix cloudbuild yaml build step args
Jan 10, 2019
4df07ba
Collapse image tags
Jan 10, 2019
14d6484
Fix waitFor
Jan 10, 2019
9a94542
Hard code tag for testing purposes
Jan 10, 2019
4410dba
Merge branch 'master' of github.com:/gojek/feast into build-push
Jan 10, 2019
036b98c
Remove hardcoded tags, and skiptests flag
Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker/core/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
FROM openjdk:8-slim
Comment thread
woop marked this conversation as resolved.
ARG RELEASE

RUN mkdir -p /usr/share/feast/ingestion

ADD core/target/feast-core-0.3.0.jar /usr/share/feast/feast-core.jar
ADD ingestion/target/feast-ingestion-0.3.0.jar /usr/share/feast/ingestion/feast-ingestion.jar
ADD core/target/feast-core-$RELEASE.jar /usr/share/feast/feast-core.jar
ADD ingestion/target/feast-ingestion-$RELEASE.jar /usr/share/feast/ingestion/feast-ingestion.jar
ADD ingestion/dependency-reduced-pom.xml /usr/share/feast/ingestion/pom.xml

ENV JOB_EXECUTABLE=/usr/share/feast/ingestion/feast-ingestion.jar
Expand Down
3 changes: 2 additions & 1 deletion docker/serving/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
FROM openjdk:8-slim
ARG RELEASE

ADD serving/target/feast-serving-0.3.0.jar /usr/share/feast/feast-serving.jar
ADD serving/target/feast-serving-$RELEASE.jar /usr/share/feast/feast-serving.jar

ENTRYPOINT ["/usr/bin/java", \
"-XX:+UseG1GC", \
Expand Down
10 changes: 10 additions & 0 deletions testing/tf/cloud-build/cloud-build.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
resource "google_cloudbuild_trigger" "build_trigger" {
project = "${var.gcp_project}"
trigger_template {
branch_name = "master"
tag_name = "^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$"
project = "${var.gcp_project}"
repo_name = "http://github.com/gojek/feast"
}
filename = "testing/tf/cloud-build/cloudbuild.yaml"
}
20 changes: 20 additions & 0 deletions testing/tf/cloud-build/cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
steps:
- name: maven:3.6.0-jdk-8-slim
args: ['mvn', 'clean', 'install', '-Drevision=$TAG_NAME']
id: build-jars

- name: "gcr.io/cloud-builders/docker"
args: ['build', '-t', 'gcr.io/$PROJECT_ID/feast-core:$TAG_NAME', '-t', 'gcr.io/$PROJECT_ID/feast-core:latest', '--build-arg', 'RELEASE=$TAG_NAME', '-f', './docker/core/Dockerfile', '.']
id: docker-core
waitFor:
- build-jars

- name: "gcr.io/cloud-builders/docker"
args: ['build', '-t', 'gcr.io/$PROJECT_ID/feast-serving:$TAG_NAME', '-t', 'gcr.io/$PROJECT_ID/feast-serving:latest', '--build-arg', 'RELEASE=$TAG_NAME', '-f', './docker/serving/Dockerfile', '.']
id: docker-serving
waitFor:

- build-jars

timeout: 1200s
images: ['gcr.io/$PROJECT_ID/feast-core:latest', 'gcr.io/$PROJECT_ID/feast-core:$TAG_NAME', 'gcr.io/$PROJECT_ID/feast-serving:latest', 'gcr.io/$PROJECT_ID/feast-serving:$TAG_NAME']
3 changes: 3 additions & 0 deletions testing/tf/cloud-build/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
variable "gcp_project" {
description = "GCP Project name"
}