Skip to content

feat: Hybrid offline store #5510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
Jul 15, 2025
Merged

feat: Hybrid offline store #5510

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c738a8e
add hybrid offline store
HaoXuAI Jul 13, 2025
b765b5e
add hybrid offline store
HaoXuAI Jul 13, 2025
fd695e8
fix source type
HaoXuAI Jul 14, 2025
02b2cdb
update doc
HaoXuAI Jul 14, 2025
bc379f5
update doc
HaoXuAI Jul 14, 2025
d338885
update doc
HaoXuAI Jul 14, 2025
5af1cf2
update doc
HaoXuAI Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Jul 14, 2025
commit 02b2cdbe8d1c590553732c7207068d060e3df4e1
15 changes: 15 additions & 0 deletions sdk/python/feast/infra/offline_stores/hybrid_offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,21 @@ def get_historical_features(
project: str,
full_feature_names: bool = False,
) -> RetrievalJob:
# TODO: Multiple data sources can be supported when feature store use compute engine
# for getting historical features
data_source = None
for feature_view in feature_views:
if not feature_view.batch_source:
raise ValueError(
f"HybridOfflineStore only supports feature views with DataSource as source. "
)
if not data_source:
data_source = feature_view.batch_source
elif data_source != feature_view.batch_source:
raise ValueError(
"All feature views must have the same batch source for HybridOfflineStore."
)

store = HybridOfflineStore()._get_offline_store_for_feature_view(
feature_views[0], config
)
Expand Down