Skip to content

feat: Update Spark Compute read source node to be able to use other data sources #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 3 commits into from
Jun 11, 2025
Merged

feat: Update Spark Compute read source node to be able to use other data sources #5445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e93b502
feat: Make Spark Compute able to use other source
HaoXuAI Jun 11, 2025
0b89d50
feat: Make Spark Compute able to use other source
HaoXuAI Jun 11, 2025
08295bf
Merge branch 'master' into spark-compute-patch
HaoXuAI Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Make Spark Compute able to use other source 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Jun 11, 2025
commit e93b502960d8613a8aefbc930e3a5201d584f62e
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/compute_engines/spark/feature_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def build_source_node(self):
source = self.feature_view.batch_source
start_time = self.task.start_time
end_time = self.task.end_time
node = SparkReadNode("source", source, start_time, end_time)
node = SparkReadNode("source", source, self.spark_session, start_time, end_time)
self.nodes.append(node)
return node

Expand Down
7 changes: 6 additions & 1 deletion sdk/python/feast/infra/compute_engines/spark/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ def __init__(
self,
name: str,
source: DataSource,
spark_session: SparkSession,
start_time: Optional[datetime] = None,
end_time: Optional[datetime] = None,
):
super().__init__(name)
self.source = source
self.spark_session = spark_session
self.start_time = start_time
self.end_time = end_time

Expand All @@ -72,7 +74,10 @@ def execute(self, context: ExecutionContext) -> DAGValue:
start_time=self.start_time,
end_time=self.end_time,
)
spark_df = cast(SparkRetrievalJob, retrieval_job).to_spark_df()
if isinstance(retrieval_job, SparkRetrievalJob):
spark_df = cast(SparkRetrievalJob, retrieval_job).to_spark_df()
else:
spark_df = self.spark_session.createDataFrame(retrieval_job.to_arrow())

return DAGValue(
data=spark_df,
Expand Down