Skip to content

[Bug] Clear all the futures when sync is called. (#501) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khorshuheng merged 1 commit into from
Mar 17, 2020
Merged

[Bug] Clear all the futures when sync is called. (#501) #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ingestion/src/main/java/feast/store/serving/redis/RedisStandaloneIngestionClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ public boolean isConnected() {
public void sync() {
// Wait for some time for futures to complete
// TODO: should this be configurable?
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
futures.clear();
try {
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
} finally {
futures.clear();
}
}

@Override
Expand Down