Skip to content

fix: Fix NumPy - PyArrow array type mapping in Trino offline store #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 3 commits into from
Jun 4, 2025
Merged

fix: Fix NumPy - PyArrow array type mapping in Trino offline store #5393

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6610a75
fix: remove forced schema when converting pandas to pyarrow table
ebolblga May 27, 2025
dd118d6
fix: add arrays to trino supported types in docs
ebolblga May 27, 2025
cd1f210
chore: linting
ebolblga May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: remove forced schema when converting pandas to pyarrow table 
Signed-off-by: ebolblga <kkochanovskiy@gmail.com>
  • Loading branch information
@ebolblga
ebolblga committed Jun 3, 2025
commit 6610a75b0f28e5274d23eb525d3e38433919661d
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def _to_df_internal(self, timeout: Optional[int] = None) -> pd.DataFrame:
def _to_arrow_internal(self, timeout: Optional[int] = None) -> pyarrow.Table:
"""Return payrrow dataset as synchronously including on demand transforms"""
return pyarrow.Table.from_pandas(
self._to_df_internal(timeout=timeout), schema=self.pyarrow_schema
self._to_df_internal(timeout=timeout)
)

def to_sql(self) -> str:
Expand Down