Skip to content

feat: Add s3 storage-based registry store in Go feature server #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 7 commits into from
May 13, 2025
Merged

feat: Add s3 storage-based registry store in Go feature server #5336

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69c80fc
fix: upgrade protobuf version, make `protos` directory beforehand
younghun-jo-levit-com May 7, 2025
466cdd0
feat: add aws s3 storage based registry store
younghun-jo-levit-com May 7, 2025
5734012
chore: add aws s3 api related pkgs
younghun-jo-levit-com May 7, 2025
70bd018
style: remove my custom comment
younghun-jo-levit-com May 7, 2025
6a8f614
refact: separate s3 registry file from `local.go`
younghun-jo-levit-com May 8, 2025
dc576af
feat: add if-statement in Makefile on linux arm64 os-platform
iamcodingcat May 9, 2025
4862622
feat: add test-code for s3 registry store
iamcodingcat May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: remove my custom comment 
Signed-off-by: iamcodingcat <joyh951021@gmail.com>
  • Loading branch information
@younghun-jo-levit-com @iamcodingcat
younghun-jo-levit-com authored and iamcodingcat committed May 13, 2025
commit 70bd018edcd8978ee3a6fda7a83c4a11e02518a3
2 changes: 1 addition & 1 deletion go/internal/feast/registry/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func NewRegistry(registryConfig *RegistryConfig, repoPath string, project string
func (r *Registry) InitializeRegistry() error {
_, err := r.getRegistryProto()
if err != nil {
if _, ok := r.registryStore.(*FileRegistryStore); ok { // S3에는 굳이 연동할 필요 없어 보임. 오히려 이로 인해 정상적이던 s3 내의 레지스트리 파일이 초기화된 파일로 덮어쓰기 될 수도 있지 않음?
if _, ok := r.registryStore.(*FileRegistryStore); ok {
Copy link
Copy Markdown
Contributor Author

@iamcodingcat iamcodingcat May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't apply if statement in case that registry store is S3RegistryStore. because this initialized empty registry store is likely to overwrite normal registry file in s3 storage. Of course, this case is when the err of r.getRegistryProto() method is the network error not abnormal file in s3 storage.

log.Error().Err(err).Msg("Registry Initialization Failed")
return err
}
Expand Down