Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
56e0d01
Set default project on python client and create non existing projects…
Mar 12, 2020
e7a1a39
Encode feature row before storing in Redis (#530)
khorshuheng Mar 13, 2020
f50de61
Update Feast 0.5 roadmap
woop Mar 14, 2020
afe9542
Reduce sleep interval duration for thread that listens for messages (…
davidheryanto Mar 15, 2020
fb893de
Update base Docker image for building Feast Serving image (#535)
davidheryanto Mar 16, 2020
3b15b14
Add Format and Lint to Makefile (#545)
woop Mar 18, 2020
28f02d2
Refactor Feast CLI/SDK configuration (#551)
woop Mar 19, 2020
a72e212
Serving should not throw exception when key not found in Redis
khorshuheng Mar 19, 2020
18235a9
Fix lint/format typo in Makefile
woop Mar 20, 2020
2830854
Add Feast CI image and infra housekeeping (#558)
woop Mar 21, 2020
ee66f65
Fix Python Formatting
woop Mar 21, 2020
64e6d63
Remove isort checking since it is non-deterministic
woop Mar 21, 2020
6a79015
GitBook: [master] 10 pages and one asset modified
ches Mar 21, 2020
1c15f65
Add GitHub Action for Linting (#559)
woop Mar 21, 2020
5ff4556
GitBook: [master] one page modified
woop Mar 22, 2020
e01c9a6
GitBook: [master] 14 pages and 2 assets modified
woop Mar 22, 2020
d9f6875
GitBook: [master] 3 pages modified
woop Mar 22, 2020
83bc621
GitBook: [master] 14 pages and one asset modified
woop Mar 22, 2020
2d45e9b
Implement unit tests on GitHub Actions (#560)
woop Mar 23, 2020
e8d6e99
Add index for join table for jobs-featuresets relation (#566)
Mar 25, 2020
9facd2e
Add pollingInterval config option (#565)
Mar 25, 2020
901e260
Fix runner to string inconsistency (#575)
mrzzy Mar 27, 2020
90debca
Fixed bug in featurset proto to model conversion in DataflowJobManage…
mrzzy Mar 27, 2020
8098bcc
Fix slack link. Fix broken Gitbook documentation.
woop Mar 27, 2020
75f3b78
Fix folders/naming for documentation
woop Mar 27, 2020
8a7be68
Changelog v0.4.7 (#579)
khorshuheng Mar 27, 2020
8b4509a
Add badges and rename linting to code standards (#581)
woop Mar 28, 2020
2ee238a
Fix for extra keys throwing an error (#570)
Mar 28, 2020
33cfbf9
Add Telco Churn Tutorial with XGBoost and Feast (#561)
woop Mar 28, 2020
41e1cf0
GitBook: [master] 3 pages modified
woop Mar 28, 2020
e4da59d
Disable tests that should be manual or that exist in GitHub Actions (…
woop Mar 28, 2020
de3fd2b
Fix caching for maven in unit-tests.yml
woop Mar 28, 2020
880269b
Enforce JDK 11 for development, but build Ingestion to target Java 8 …
ches Mar 28, 2020
314369d
Add __all__ exports to Python SDK (#587)
woop Mar 29, 2020
dad20ff
Allow tests to run on non-master branches (#588)
woop Mar 29, 2020
e8a12f4
Add stale bot to Feast project
woop Mar 29, 2020
9fc566a
Merge branch 'default-project' of github.com:Joostrothweiler/feast in…
Apr 2, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 60
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 7
# Issues with these labels will never be considered stale
exemptLabels:
- pinned
- security
- keep-open
# Label to use when marking an issue as stale
staleLabel: wontfix
# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: false
32 changes: 32 additions & 0 deletions .github/workflows/code_standards.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: code standards

on: [push, pull_request]

jobs:
lint-java:
container: gcr.io/kf-feast/feast-ci:latest
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v2
- name: lint java
run: make lint-java

lint-python:
container: gcr.io/kf-feast/feast-ci:latest
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v2
- name: install dependencies
run: make install-python-ci-dependencies
- name: lint python
run: make lint-python

lint-go:
container: gcr.io/kf-feast/feast-ci:latest
runs-on: [ubuntu-latest]
steps:
- uses: actions/checkout@v2
- name: install dependencies
run: make install-go-ci-dependencies
- name: lint go
run: make lint-go
41 changes: 41 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: unit tests

on: [push, pull_request]

jobs:
unit-test-java:
runs-on: ubuntu-latest
container: gcr.io/kf-feast/feast-ci:latest
name: unit test java
steps:
- uses: actions/checkout@v1
- uses: actions/cache@v1
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: test java
run: make test-java

unit-test-python:
runs-on: ubuntu-latest
container: gcr.io/kf-feast/feast-ci:latest
name: unit test python
steps:
- uses: actions/checkout@v1
- name: install python
run: make install-python
- name: test python
run: make test-python

unit-test-go:
runs-on: ubuntu-latest
container: gcr.io/kf-feast/feast-ci:latest
name: unit test go
steps:
- uses: actions/checkout@v1
- name: install dependencies
run: make compile-protos-go
- name: test go
run: make test-go
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,8 @@ dmypy.json
.flattened-pom.xml

sdk/python/docs/html
sdk/python/feast/core/
sdk/python/feast/serving/
sdk/python/feast/storage/
sdk/python/feast/types/
sdk/python/tensorflow_metadata
13 changes: 13 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
repos:
- repo: local
hooks:
- id: format
name: Format
stages: [commit]
language: system
entry: make format
- id: lint
name: Lint
stages: [commit]
language: system
entry: make lint
49 changes: 21 additions & 28 deletions .prow/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,10 @@ presubmits:
gojek/feast:
- name: test-core-and-ingestion
decorate: true
always_run: true
spec:
containers:
- image: maven:3.6-jdk-11
command: [".prow/scripts/test-core-ingestion.sh"]
command: ["infra/scripts/test-core-ingestion.sh"]
resources:
requests:
cpu: "2000m"
Expand All @@ -81,7 +80,7 @@ presubmits:
spec:
containers:
- image: maven:3.6-jdk-8
command: [".prow/scripts/test-core-ingestion.sh"]
command: ["infra/scripts/test-core-ingestion.sh"]
resources:
requests:
cpu: "2000m"
Expand All @@ -91,11 +90,10 @@ presubmits:

- name: test-serving
decorate: true
always_run: true
spec:
containers:
- image: maven:3.6-jdk-11
command: [".prow/scripts/test-serving.sh"]
command: ["infra/scripts/test-serving.sh"]
skip_branches:
- ^v0\.(3|4)-branch$

Expand All @@ -105,17 +103,16 @@ presubmits:
spec:
containers:
- image: maven:3.6-jdk-8
command: [".prow/scripts/test-serving.sh"]
command: ["infra/scripts/test-serving.sh"]
branches:
- ^v0\.(3|4)-branch$

- name: test-java-sdk
decorate: true
always_run: true
spec:
containers:
- image: maven:3.6-jdk-11
command: [".prow/scripts/test-java-sdk.sh"]
command: ["infra/scripts/test-java-sdk.sh"]
skip_branches:
- ^v0\.(3|4)-branch$

Expand All @@ -125,33 +122,30 @@ presubmits:
spec:
containers:
- image: maven:3.6-jdk-8
command: [".prow/scripts/test-java-sdk.sh"]
command: ["infra/scripts/test-java-sdk.sh"]
branches:
- ^v0\.(3|4)-branch$

- name: test-python-sdk
decorate: true
always_run: true
spec:
containers:
- image: python:3.7
command: [".prow/scripts/test-python-sdk.sh"]
command: ["infra/scripts/test-python-sdk.sh"]

- name: test-golang-sdk
decorate: true
always_run: true
spec:
containers:
- image: golang:1.13
command: [".prow/scripts/test-golang-sdk.sh"]
command: ["infra/scripts/test-golang-sdk.sh"]

- name: test-end-to-end
decorate: true
always_run: true
spec:
containers:
- image: maven:3.6-jdk-11
command: [".prow/scripts/test-end-to-end.sh"]
command: ["infra/scripts/test-end-to-end.sh"]
resources:
requests:
cpu: "6"
Expand All @@ -165,7 +159,7 @@ presubmits:
spec:
containers:
- image: maven:3.6-jdk-8
command: [".prow/scripts/test-end-to-end.sh"]
command: ["infra/scripts/test-end-to-end.sh"]
resources:
requests:
cpu: "6"
Expand All @@ -175,15 +169,14 @@ presubmits:

- name: test-end-to-end-batch
decorate: true
always_run: true
spec:
volumes:
- name: service-account
secret:
secretName: feast-service-account
containers:
- image: maven:3.6-jdk-11
command: [".prow/scripts/test-end-to-end-batch.sh"]
command: ["infra/scripts/test-end-to-end-batch.sh"]
resources:
requests:
cpu: "6"
Expand All @@ -204,7 +197,7 @@ presubmits:
secretName: feast-service-account
containers:
- image: maven:3.6-jdk-8
command: [".prow/scripts/test-end-to-end-batch.sh"]
command: ["infra/scripts/test-end-to-end-batch.sh"]
resources:
requests:
cpu: "6"
Expand All @@ -226,7 +219,7 @@ postsubmits:
- sh
- -c
- |
.prow/scripts/publish-python-sdk.sh \
infra/scripts/publish-python-sdk.sh \
--directory-path sdk/python --repository pypi
volumeMounts:
- name: pypirc
Expand All @@ -250,7 +243,7 @@ postsubmits:
command:
- bash
- -c
- .prow/scripts/publish-java-sdk.sh --revision ${PULL_BASE_REF:1}
- infra/scripts/publish-java-sdk.sh --revision ${PULL_BASE_REF:1}
volumeMounts:
- name: gpg-keys
mountPath: /etc/gpg
Expand Down Expand Up @@ -282,7 +275,7 @@ postsubmits:
command:
- bash
- -c
- .prow/scripts/publish-java-sdk.sh --revision ${PULL_BASE_REF:1}
- infra/scripts/publish-java-sdk.sh --revision ${PULL_BASE_REF:1}
volumeMounts:
- name: gpg-keys
mountPath: /etc/gpg
Expand Down Expand Up @@ -311,19 +304,19 @@ postsubmits:
- bash
- -c
- |
.prow/scripts/download-maven-cache.sh \
infra/scripts/download-maven-cache.sh \
--archive-uri gs://feast-templocation-kf-feast/.m2.2019-10-24.tar \
--output-dir $PWD/

if [ $PULL_BASE_REF == "master" ]; then

.prow/scripts/publish-docker-image.sh \
infra/scripts/publish-docker-image.sh \
--repository gcr.io/kf-feast/feast-core \
--tag dev \
--file infra/docker/core/Dockerfile \
--google-service-account-file /etc/gcloud/service-account.json

.prow/scripts/publish-docker-image.sh \
infra/scripts/publish-docker-image.sh \
--repository gcr.io/kf-feast/feast-serving \
--tag dev \
--file infra/docker/serving/Dockerfile \
Expand All @@ -337,13 +330,13 @@ postsubmits:

else

.prow/scripts/publish-docker-image.sh \
infra/scripts/publish-docker-image.sh \
--repository gcr.io/kf-feast/feast-core \
--tag ${PULL_BASE_REF:1} \
--file infra/docker/core/Dockerfile \
--google-service-account-file /etc/gcloud/service-account.json

.prow/scripts/publish-docker-image.sh \
infra/scripts/publish-docker-image.sh \
--repository gcr.io/kf-feast/feast-serving \
--tag ${PULL_BASE_REF:1} \
--file infra/docker/serving/Dockerfile \
Expand Down Expand Up @@ -400,7 +393,7 @@ postsubmits:
sed -i "/version: /c\version: ${PULL_BASE_REF:1}" infra/charts/feast/charts/feast-serving/Chart.yaml
sed -i "/ tag: /c\ tag: ${PULL_BASE_REF:1}" infra/charts/feast/charts/feast-serving/values.yaml

.prow/scripts/sync-helm-charts.sh
infra/scripts/sync-helm-charts.sh
volumeMounts:
- name: service-account
mountPath: /etc/gcloud/service-account.json
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

## [v0.4.7](https://github.com/gojek/feast/tree/v0.4.7) (2020-03-17)

[Full Changelog](https://github.com/gojek/feast/compare/v0.4.6...v0.4.7)

**Merged pull requests:**
- Add log4j-web jar to core and serving. [\#498](https://github.com/gojek/feast/pull/498) ([Yanson](https://github.com/Yanson))
- Clear all the futures when sync is called. [\#501](https://github.com/gojek/feast/pull/501) ([lavkesh](https://github.com/lavkesh))
- Encode feature row before storing in Redis [\#530](https://github.com/gojek/feast/pull/530) ([khorshuheng](https://github.com/khorshuheng))
- Remove transaction when listing projects [\#522](https://github.com/gojek/feast/pull/522) ([davidheryanto](https://github.com/davidheryanto))
- Remove unused ingestion deps [\#520](https://github.com/gojek/feast/pull/520) ([ches](https://github.com/ches))
- Parameterize end to end test scripts. [\#433](https://github.com/gojek/feast/pull/433) ([Yanson](https://github.com/Yanson))
- Replacing Jedis With Lettuce in ingestion and serving [\#485](https://github.com/gojek/feast/pull/485) ([lavkesh](https://github.com/lavkesh))

## [v0.4.6](https://github.com/gojek/feast/tree/v0.4.6) (2020-02-26)

[Full Changelog](https://github.com/gojek/feast/compare/v0.4.5...v0.4.6)
Expand Down
Loading