Skip to content

feat: Add feature view tags to dynamo tags #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Apr 29, 2025
Merged

feat: Add feature view tags to dynamo tags #5291

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40cb583
add feature view tags to dynamo tags
robhowley Apr 23, 2025
009f829
add tag update helper method
robhowley Apr 23, 2025
61a21aa
fix tag change checks
robhowley Apr 23, 2025
ea25f25
simplify and just untag all to re add
robhowley Apr 23, 2025
c7548e1
dont do tag updates for new tables
robhowley Apr 23, 2025
603d302
more granular tags take priority
robhowley Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add feature view tags to dynamo tags 
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
@robhowley
robhowley committed Apr 23, 2025
commit 40cb583b2bdbedd81e5f7143782daf5f3c5eb3c5
30 changes: 19 additions & 11 deletions sdk/python/feast/infra/online_stores/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,19 +167,27 @@ def update(
online_config.endpoint_url,
online_config.session_based_auth,
)
# Add Tags attribute to creation request only if configured to prevent
# TagResource permission issues, even with an empty Tags array.
kwargs = (
{
"Tags": [

online_tags = online_config.tags or {}
common_tags = [
{"Key": key, "Value": value}
for key, value in online_tags.items()
]

for table_instance in tables_to_keep:
table_tags = common_tags + (
[
{"Key": key, "Value": value}
for key, value in online_config.tags.items()
for key, value in table_instance.tags.items()
if key not in online_tags
]
}
if online_config.tags
else {}
)
for table_instance in tables_to_keep:
if table_instance.tags
else []
)

# Add Tags attribute to creation request only if configured to prevent
# TagResource permission issues, even with an empty Tags array.
kwargs = {"Tags": table_tags} if table_tags else {}
try:
dynamodb_resource.create_table(
TableName=_get_table_name(online_config, config, table_instance),
Expand Down
Loading