Skip to content

feat: Enable write node for compute engine #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoXuAI merged 11 commits into from
Apr 24, 2025
Merged

feat: Enable write node for compute engine #5287

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f6d527
enable write node
HaoXuAI Apr 20, 2025
ff1f400
fix linting
HaoXuAI Apr 20, 2025
91f41cb
remove debug
HaoXuAI Apr 20, 2025
1f54560
rename module
HaoXuAI Apr 20, 2025
3d97656
fix linting
HaoXuAI Apr 20, 2025
145c58e
fix linting
HaoXuAI Apr 20, 2025
62e9b3d
fix linting
HaoXuAI Apr 21, 2025
a09b7e5
fix fv offline
HaoXuAI Apr 21, 2025
155d1ed
fix feature view proto
HaoXuAI Apr 21, 2025
3af968b
fix write node
HaoXuAI Apr 22, 2025
7d23438
fix write node
HaoXuAI Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Apr 21, 2025
commit 62e9b3d51c59eddf615d191366e0ca1b92389f15
11 changes: 11 additions & 0 deletions sdk/python/tests/integration/compute_engines/spark/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
from tests.integration.feature_repos.universal.online_store.redis import (
RedisOnlineStoreCreator,
)
from tests.utils.e2e_test_validation import _check_offline_and_online_features

now = datetime.now()
today = datetime.today()
Expand Down Expand Up @@ -242,6 +243,16 @@ def tqdm_builder(length):
spark_materialize_job = engine.materialize(task)

assert spark_materialize_job.status() == MaterializationJobStatus.SUCCEEDED

_check_offline_and_online_features(
fs=fs,
fv=driver_stats_fv,
driver_id=1,
event_timestamp=now,
expected_value=0.3,
full_feature_names=True,
check_offline_store=True,
)
finally:
spark_environment.teardown()

Expand Down
Loading