Skip to content

feat: Offline store update pull_all_from_table_or_query to make timestampfield optional #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 20 commits into from
Apr 20, 2025
Merged

feat: Offline store update pull_all_from_table_or_query to make timestampfield optional #5281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
112014e
Update offline store pull all API date field optional
HaoXuAI Apr 18, 2025
c75c264
Update offline store pull all API date field optional
HaoXuAI Apr 18, 2025
b62fd1a
update
HaoXuAI Apr 18, 2025
8b5bdae
update
HaoXuAI Apr 18, 2025
e92d015
update
HaoXuAI Apr 18, 2025
4765d8f
fix test
HaoXuAI Apr 18, 2025
0bbdbbc
update source read node
HaoXuAI Apr 18, 2025
0336318
fix linting
HaoXuAI Apr 18, 2025
ac03a75
fix linting
HaoXuAI Apr 18, 2025
0033b9c
fix linting
HaoXuAI Apr 18, 2025
743a490
fix linting
HaoXuAI Apr 18, 2025
4285b5f
fix linting
HaoXuAI Apr 18, 2025
618c4b8
fix test
HaoXuAI Apr 18, 2025
afcaf9c
fix test
HaoXuAI Apr 18, 2025
8e02747
fix test
HaoXuAI Apr 18, 2025
71daec2
fix test
HaoXuAI Apr 18, 2025
23a0fb4
fix test
HaoXuAI Apr 18, 2025
bcf1d7a
fix test
HaoXuAI Apr 18, 2025
89ad0da
fix test
HaoXuAI Apr 18, 2025
cdae95b
fix test
HaoXuAI Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test 
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
  • Loading branch information
@HaoXuAI
HaoXuAI committed Apr 18, 2025
commit 89ad0da9fbd1295d2a4f38c2568d52faf6f599e6
6 changes: 5 additions & 1 deletion sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,11 @@ def pull_all_from_table_or_query(
+ [timestamp_field]
)
timestamp_filter = get_timestamp_filter_sql(
Copy link
Copy Markdown
Collaborator Author

@HaoXuAI HaoXuAI Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major change: get the timestamp filter from get_timestamp_filter_sql

start_date, end_date, timestamp_field, quote_fields=False, cast_style="timestamp_func"
start_date,
end_date,
timestamp_field,
quote_fields=False,
cast_style="timestamp_func",
)
query = f"""
SELECT {field_string}
Expand Down
3 changes: 2 additions & 1 deletion sdk/python/feast/infra/offline_stores/offline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ def get_timestamp_filter_sql(
date_partition_column: optional partition column (for pruning)
tz: optional timezone for datetime inputs
cast_style: one of:
- "timestamp_func": TIMESTAMP('...') → Snowflake, BigQuery, Athena
- "timestamp": TIMESTAMP '...' → Common Sql engine Snowflake, Redshift etc.
- "timestamp_func": TIMESTAMP('...') → BigQuery, Couchbase etc.
- "timestamptz": '...'::timestamptz → PostgreSQL
- "raw": '...' → no cast, string only
date_time_separator: separator for datetime strings (default is "T")
Expand Down
Loading