Skip to content

ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Apr 7, 2025
Merged

ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir #5234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move offline source build requirements files 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
  • Loading branch information
@tchughesiv
tchughesiv committed Apr 7, 2025
commit 249227e3a4c79189c3542c00200c9908b784f2b8
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ lock-python-dependencies-all:
pixi run --environment $(call get_env_name,3.11) --manifest-path infra/scripts/pixi/pixi.toml \
"uv pip compile -p 3.11 --no-strip-extras setup.py --extra pandas-build \
--generate-hashes --output-file sdk/python/requirements/py3.11-pandas-requirements.txt"
pixi run --environment $(call get_env_name,3.11) --manifest-path infra/scripts/pixi/pixi.toml \
"uv pip compile -p 3.11 --no-strip-extras setup.py --extra postgres-source \
--output-file sdk/python/requirements/py3.11-postgres-source-requirements.txt"
pixi run --environment $(call get_env_name,3.11) --manifest-path infra/scripts/pixi/pixi.toml \
"uv pip compile -p 3.11 --no-strip-extras setup.py --extra minimal-sdist-build \
--no-emit-package milvus-lite \
Expand Down
2 changes: 1 addition & 1 deletion infra/scripts/offline-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ cachi2 fetch-deps \
],
"requirements_build_files": [
"sdk/python/feast/infra/feature_servers/multicloud/offline/pyarrow17-wheel-build-requirements.txt",
"sdk/python/feast/infra/feature_servers/multicloud/offline/psycopg3.2.5-wheel-build-requirements.txt",
"sdk/python/requirements/py3.11-sdist-requirements.txt",
"sdk/python/requirements/py3.11-pandas-requirements.txt",
"sdk/python/requirements/py3.11-postgres-source-requirements.txt",
"sdk/python/requirements/py3.11-addtl-sources-requirements.txt"
],
"allow_binary": "false"
Expand Down
6 changes: 1 addition & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ docs = ["feast[ci]"]
# used for the 'feature-server' container image build
minimal = ["feast[aws, gcp, snowflake, redis, go, mysql, postgres, opentelemetry, grpcio, k8s, duckdb, milvus]"]

# extras for a disconnected build from source (pandas, postgres-source, sdist)
# extras for a disconnected build from source (pandas, sdist, etc.)
numpy-build = [
"meson-python<0.16.0,>=0.15.0",
"Cython<3.1,>=0.29.34",
Expand All @@ -191,10 +191,6 @@ pandas-build = [
"oldest-supported-numpy>=2022.8.16,<2023.8.3",
"versioneer[toml]==0.29",
]
postgres-source = [
"psycopg @ git+https://github.com/psycopg/psycopg@3.2.5#subdirectory=psycopg",
"psycopg-pool @ git+https://github.com/psycopg/psycopg@3.2.6#subdirectory=psycopg_pool",
]
addtl-sources = [
# python-dateutil build deps
"python-dateutil==2.9.0",
Expand Down
2 changes: 2 additions & 0 deletions .../feast/infra/feature_servers/multicloud/offline/psycopg3.2.5-wheel-build-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
psycopg @ git+https://github.com/psycopg/psycopg@664b2a12d68d9f826b58ea004f05460448e78bca#subdirectory=psycopg
psycopg-pool @ git+https://github.com/psycopg/psycopg@dfc113613c067600355a14c2e4010d03cbef51bd#subdirectory=psycopg_pool
4 changes: 1 addition & 3 deletions sdk/python/feast/infra/feature_servers/multicloud/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
# keep VERSION on line #2, this is critical to release CI
feast[aws,gcp,snowflake,redis,go,mysql,postgres,opentelemetry,grpcio,k8s,duckdb,milvus] == 0.48.0
# the following can be used instead w/ feast 0.48.0+
# feast[minimal] == 0.48.0
feast[minimal] == 0.48.0
178 changes: 0 additions & 178 deletions sdk/python/requirements/py3.11-postgres-source-requirements.txt
View file
Open in desktop

This file was deleted.

Loading