Skip to content

feat: Qdrant online store add retrieve_online_documents_v2 #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YassinNouh21 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Qdrant online store add retrieve_online_documents_v2 #5211

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b7c98a
feat: qdrant add `retrieve_online_documents_v2`
YassinNouh21 Apr 2, 2025
c1ef109
formatting
YassinNouh21 Apr 2, 2025
660fe50
feat: add Qdrant online store support and retrieval tests
YassinNouh21 Apr 2, 2025
519aa9f
Merge master and fix conflicts in Qdrant online store implementation
YassinNouh21 Apr 5, 2025
3a4d4e0
Fix Qdrant entity key handling in online store implementation
YassinNouh21 Apr 5, 2025
e4e0383
Fix entity key deserialization in Qdrant online store
YassinNouh21 Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Qdrant entity key handling in online store implementation
  • Loading branch information
@YassinNouh21
YassinNouh21 committed Apr 5, 2025
commit 3a4d4e0f7ce6aa8a3635fc84c3e8cef1d4576cef
24 changes: 19 additions & 5 deletions sdk/python/feast/infra/online_stores/qdrant_online_store/qdrant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,20 @@ def online_read(
) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
conditions: List[models.Condition] = []
if entity_keys:
# Convert entity keys to the string format stored in Qdrant
entity_key_strs = []
for entity_key in entity_keys:
entity_key_bin = serialize_entity_key(
entity_key,
entity_key_serialization_version=config.entity_key_serialization_version,
)
entity_key_str = base64.b64encode(entity_key_bin).decode("utf-8")
entity_key_strs.append(entity_key_str)

conditions.append(
models.FieldCondition(
key="entity_key",
match=models.MatchAny(any=entity_keys), # type: ignore
match=models.MatchAny(any=entity_key_strs),
)
)

Expand Down Expand Up @@ -325,7 +335,10 @@ def retrieve_online_documents(
)
for point in points:
payload = point.payload or {}
entity_key = str(payload.get("entity_key"))
entity_key_str = payload.get("entity_key")
if not entity_key_str:
continue

feature_value = str(payload.get("feature_value"))
timestamp_str = str(payload.get("timestamp"))
timestamp = datetime.strptime(timestamp_str, "%Y-%m-%dT%H:%M:%S.%f")
Expand All @@ -338,7 +351,7 @@ def retrieve_online_documents(

result.append(
_build_retrieve_online_document_record(
entity_key,
entity_key_str,
base64.b64decode(feature_value),
vector_value,
distance,
Expand Down Expand Up @@ -543,8 +556,9 @@ def retrieve_online_documents_v2(
raw_entity_key = payload.get("entity_key")
if not raw_entity_key:
continue
entity_key_str = cast(str, raw_entity_key)


entity_key_str = raw_entity_key

# Handle feature name
feature_name = payload.get("feature_name", "")
feature_value_encoded = payload.get("feature_value")
Expand Down