Skip to content

feat: Added global registry search support in Feast UI #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 4 commits into from
Mar 27, 2025
Merged

feat: Added global registry search support in Feast UI #5195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
598abc2
feat: Added global search feature at UI homepage
ntkathole Mar 27, 2025
d52414a
feat: Made searched items linkable
ntkathole Mar 27, 2025
c3f952a
feat: RegistrySearch component
ntkathole Mar 27, 2025
68e9568
fix: fix load elements only after registry load
ntkathole Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Made searched items linkable 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
  • Loading branch information
@ntkathole
ntkathole committed Mar 27, 2025
commit d52414ab9d03e61f80a010abef8c4b6bf10546fa
88 changes: 88 additions & 0 deletions ui/src/components/RegistrySearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
import React, { useState } from "react";
import { EuiText, EuiFieldSearch, EuiSpacer } from "@elastic/eui";
import EuiCustomLink from "./EuiCustomLink";

interface RegistrySearchProps {
categories: {
name: string;
data: any[];
getLink: (item: any) => string;
}[];
}

const RegistrySearch: React.FC<RegistrySearchProps> = ({ categories }) => {
const [searchText, setSearchText] = useState("");

const searchResults = categories.map(({ name, data, getLink }) => {
const filteredItems = searchText
? data.filter((item) => {
const itemName =
"name" in item
? String(item.name)
: "spec" in item && item.spec && "name" in item.spec
? String(item.spec.name ?? "Unknown")
: "Unknown";

return itemName.toLowerCase().includes(searchText.toLowerCase());
})
: [];

return { name, items: filteredItems, getLink };
});

return (
<>
<EuiSpacer size="l" />
<EuiText>
<h3>Search in registry</h3>
</EuiText>
<EuiFieldSearch
placeholder="Search across Feature Views, Features, Entities, etc."
value={searchText}
onChange={(e) => setSearchText(e.target.value)}
isClearable
fullWidth
/>
<EuiSpacer size="m" />

{searchText && (
<EuiText>
<h3>Search Results</h3>
{searchResults.some(({ items }) => items.length > 0) ? (
searchResults.map(({ name, items, getLink }, index) =>
items.length > 0 ? (
<div key={index}>
<h4>{name}</h4>
<ul>
{items.map((item, idx) => {
const itemName =
"name" in item
? item.name
: "spec" in item
? item.spec?.name
: "Unknown";

const itemLink = getLink(item);

return (
<li key={idx}>
<EuiCustomLink to={itemLink}>
{itemName}
</EuiCustomLink>
</li>
);
})}
</ul>
</div>
) : null,
)
) : (
<p>No matches found.</p>
)}
</EuiText>
)}
</>
);
};

export default RegistrySearch;
73 changes: 58 additions & 15 deletions ui/src/pages/ProjectOverviewPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import ObjectsCountStats from "../components/ObjectsCountStats";
import ExplorePanel from "../components/ExplorePanel";
import useLoadRegistry from "../queries/useLoadRegistry";
import RegistryPathContext from "../contexts/RegistryPathContext";
import EuiCustomLink from "../components/EuiCustomLink";
import { useParams } from "react-router-dom";

const ProjectOverviewPage = () => {
useDocumentTitle("Feast Home");
Expand All @@ -24,12 +26,44 @@ const ProjectOverviewPage = () => {

const [searchText, setSearchText] = useState("");

const { projectName } = useParams<{ projectName: string }>();

const categories = [
{ name: "Data Sources", data: data?.objects.dataSources || [] },
{ name: "Entities", data: data?.objects.entities || [] },
{ name: "Features", data: data?.allFeatures || [] },
{ name: "Feature Views", data: data?.mergedFVList || [] },
{ name: "Feature Services", data: data?.objects.featureServices || [] },
{
name: "Data Sources",
data: data?.objects.dataSources || [],
getLink: (item: any) => `/p/${projectName}/data-source/${item.name}`,
},
{
name: "Entities",
data: data?.objects.entities || [],
getLink: (item: any) => `/p/${projectName}/entity/${item.name}`,
},
{
name: "Features",
data: data?.allFeatures || [],
getLink: (item: any) => {
const featureView = item?.featureView;
return featureView
? `/p/${projectName}/feature-view/${featureView}/feature/${item.name}`
: "#";
},
},
{
name: "Feature Views",
data: data?.mergedFVList || [],
getLink: (item: any) => `/p/${projectName}/feature-view/${item.name}`,
},
{
name: "Feature Services",
data: data?.objects.featureServices || [],
getLink: (item: any) => {
const serviceName = item?.name || item?.spec?.name;
return serviceName
? `/p/${projectName}/feature-service/${serviceName}`
: "#";
},
},
];

const searchResults = categories.map(({ name, data }) => {
Expand Down Expand Up @@ -85,8 +119,8 @@ const ProjectOverviewPage = () => {
<EuiText>
<p>
Welcome to your new Feast project. In this UI, you can see
Data Sources, Entities, Features, Feature Views, and Feature Services
registered in Feast.
Data Sources, Entities, Features, Feature Views, and Feature
Services registered in Feast.
</p>
<p>
It looks like this project already has some objects
Expand Down Expand Up @@ -130,20 +164,29 @@ const ProjectOverviewPage = () => {
<EuiText>
<h3>Search Results</h3>
{searchResults.some(({ items }) => items.length > 0) ? (
searchResults.map(({ name, items }) =>
searchResults.map(({ name, items }, index) =>
items.length > 0 ? (
<div key={name}>
<div key={index}>
<h4>{name}</h4>
<ul>
{items.map((item, idx) => (
<li key={idx}>
{"name" in item
{items.map((item, idx) => {
const itemName =
"name" in item
? item.name
: "spec" in item
? item.spec?.name
: "Unknown"}
</li>
))}
: "Unknown";

const itemLink = categories[index].getLink(item);

return (
<li key={idx}>
<EuiCustomLink to={itemLink}>
{itemName}
</EuiCustomLink>
</li>
);
})}
</ul>
</div>
) : null,
Expand Down