Skip to content

fix: Multiple fixes in retrieval of online documents #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 6 commits into from
Mar 27, 2025
Merged

fix: Multiple fixes in retrieval of online documents #5168

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59a1f77
Fixed Retrive online documents for serialization ver 3
jyejare Mar 20, 2025
9c07b0a
Dynamic vector field name
jyejare Mar 21, 2025
b1a6662
Requested only features with values
jyejare Mar 22, 2025
912e30b
Removing the singular feature parameter for doc retrieval
jyejare Mar 26, 2025
e298d1d
Documentation and other DBs test fixes
jyejare Mar 26, 2025
436c333
Review Fixes
jyejare Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dynamic vector field name 
Signed-off-by: jyejare <jyejare@redhat.com>
  • Loading branch information
@jyejare
jyejare committed Mar 22, 2025
commit 9c07b0a8a7b80bde81412dc7ed47b281a5ce6e2a
22 changes: 17 additions & 5 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,13 +1930,25 @@ def retrieve_online_documents(
document_feature_distance_vals = [feature[5] for feature in document_features]
online_features_response = GetOnlineFeaturesResponse(results=[])
requested_feature = requested_feature or requested_features[0]
if vector_field_metadata := _get_feature_view_vector_field_metadata(
requested_feature_view
):
vector_field_name = vector_field_metadata.name
data = {
**join_key_values,
vector_field_name: document_feature_vals,
"distance": document_feature_distance_vals,
}
_requested_features = [_feature.split(":")[-1] for _feature in feature_list]
requested_features_data = {
_feature: data[_feature]
for _feature in _requested_features
if _feature in data
}
# TODO currently the requested 'features' list is not functioning as expected
utils._populate_result_rows_from_columnar(
online_features_response=online_features_response,
data={
**join_key_values,
"embedding": document_feature_vals, # Replace the hardcoded "embedding" with the actual feature name
"distance": document_feature_distance_vals,
Comment thread
franciscojavierarceo marked this conversation as resolved.
},
data=requested_features_data,
)
return OnlineResponse(online_features_response)

Expand Down
Loading