Skip to content

fix: Cant add different type of list types #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Mar 7, 2025
Merged

fix: Cant add different type of list types #5118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: added list value types 
Signed-off-by: Itay Katav <ikatav@redhat.com>
  • Loading branch information
@itay1551
itay1551 committed Mar 5, 2025
commit 958f7114f1b31822dd5a39f2112015a396f69fe8
6 changes: 6 additions & 0 deletions sdk/python/feast/type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,12 @@ def pa_to_feast_value_type(pa_type_as_str: str) -> ValueType:
"bool": ValueType.BOOL,
"null": ValueType.NULL,
"list<element: double>": ValueType.DOUBLE_LIST,
"list<element: int64>": ValueType.INT64_LIST,
"list<element: int32>": ValueType.INT32_LIST,
"list<element: str>": ValueType.STRING_LIST,
"list<element: bool>": ValueType.BOOL_LIST,
"list<element: bytes>": ValueType.BYTES_LIST,
"list<element: float>": ValueType.FLOAT_LIST,
}
value_type = type_map[pa_type_as_str]

Expand Down