fix: Validate entities when running get_online_features - #5031
Merged
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
requested review from
dmartinol,
lokeshrangineni and
shuchu
February 8, 2025 01:58
franciscojavierarceo
pushed a commit
that referenced
this pull request
Feb 17, 2025
# [0.46.0](v0.45.0...v0.46.0) (2025-02-17) ### Bug Fixes * Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed)) * Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35)) * Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a)) * Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b)) * Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447)) * Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548)) * Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4)) * Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa)) * Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca)) ### Features * Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21)) * Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d)) * Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7)) * Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7)) * Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses the issue of unexpected crashes when using feature_store.get_online_features with incorrect or missing join keys.
Specifically, it introduces validation logic in the
_get_unique_entitiesfunction to ensure that all expected join keys are present and non-empty before proceeding.If any required join keys are missing or have empty values, a KeyError is raised with a descriptive error message. Additionally, new unit tests have been added to cover various edge cases, ensuring that the function behaves as expected under different scenarios.
Changes:
sdk/python/feast/utils.py:_get_unique_entities.table_entity_valuesinto row-wise data and handle edge cases.sdk/python/tests/unit/online_store/test_online_retrieval.py:KeyErroris raised when required join keys are missing.sdk/python/tests/unit/test_unit_feature_store.py:test_get_unique_entitiestotest_get_unique_entities_successfor clarity.Which issue(s) this PR fixes:
#3270
Misc
It's worth noting, when one key is present and one is not, the retrieval will still succeed as this is expected behavior.