Skip to content

feat: Add Couchbase Columnar as an Offline Store #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 22 commits into from
Feb 28, 2025
Merged

feat: Add Couchbase Columnar as an Offline Store #5025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
db77c7e
Add Couchbase Columnar and Sync Deps
ejscribner Feb 3, 2025
9930c72
Couchbase Columnar Offline Store
ejscribner Feb 3, 2025
c6d16fb
Testing Config
ejscribner Feb 3, 2025
c14574e
Warnings for Experimental Store
ejscribner Feb 5, 2025
fa34d15
Initial Template
ejscribner Feb 5, 2025
e27202e
Temp Timeout Fix and Lint
ejscribner Feb 5, 2025
21b78c9
Initial Docs
ejscribner Feb 5, 2025
78d780e
Fixing Template
ejscribner Feb 6, 2025
8b7bbf1
Protos
ejscribner Feb 6, 2025
265fda5
Make build-sphinx
ejscribner Feb 6, 2025
d9f749d
Add info on Columnar setup to docs
ejscribner Feb 6, 2025
6e0c777
Docs Adjustment
ejscribner Feb 7, 2025
a4e1425
Lint Fix
ejscribner Feb 7, 2025
ef34493
Dispatch Timeouts
ejscribner Feb 7, 2025
37791a8
Cleanup Steps for Test Resources
ejscribner Feb 7, 2025
fcdfa0f
Remove unneccesary cleanup util file
ejscribner Feb 18, 2025
3e11eec
Refactor `couchbase` to `couchbase.offline`
ejscribner Feb 18, 2025
0cb77ae
Refactor `couchbase` online literal to `couchbase.online`
ejscribner Feb 18, 2025
c038560
Test cleanup
ejscribner Feb 18, 2025
623c1a1
Added `couchbase.offline` to operator types
ejscribner Feb 18, 2025
266302e
Add Couchbase to Roadmap for Offline, Online, and Data Source
ejscribner Feb 23, 2025
4df968b
Add `couchbase-columnar` to `pyproject.toml`
ejscribner Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Protos 
Signed-off-by: Elliot Scribner <elliot.scribner@couchbase.com>
  • Loading branch information
@ejscribner
ejscribner committed Feb 27, 2025
commit 8b7bbf103d88adb939fd64762d2b89e05cb988f2
10 changes: 10 additions & 0 deletions protos/feast/core/FeatureService.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ message LoggingConfig {
SnowflakeDestination snowflake_destination = 6;
CustomDestination custom_destination = 7;
AthenaDestination athena_destination = 8;
CouchbaseColumnarDestination couchbase_columnar_destination = 9;
}

message FileDestination {
Expand Down Expand Up @@ -95,6 +96,15 @@ message LoggingConfig {
string kind = 1;
map<string, string> config = 2;
}

message CouchbaseColumnarDestination {
// Destination database name
string database = 1;
// Destination scope name
string scope = 2;
// Destination collection name
string collection = 3;
}
}

message FeatureServiceList {
Expand Down
38 changes: 20 additions & 18 deletions sdk/python/feast/protos/feast/core/FeatureService_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

50 changes: 27 additions & 23 deletions sdk/python/feast/protos/feast/core/FeatureService_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,26 +196,6 @@ class LoggingConfig(google.protobuf.message.Message):
table_name: builtins.str = ...,
) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["table_name", b"table_name"]) -> None: ...
class CouchbaseColumnarDestination(google.protobuf.message.Message):
DESCRIPTOR: google.protobuf.descriptor.Descriptor

DATABASE_FIELD_NUMBER: builtins.int
SCOPE_FIELD_NUMBER: builtins.int
COLLECTION_FIELD_NUMBER: builtins.int
database: builtins.str
"""Destination database name"""
scope: builtins.str
"""Destination scope name"""
collection: builtins.str
"""Destination collection name"""
def __init__(
self,
*,
database: builtins.str = ...,
scope: builtins.str = ...,
collection: builtins.str = ...,
) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["database", b"database", "scope", b"scope", "collection", b"collection"]) -> None: ...

class CustomDestination(google.protobuf.message.Message):
DESCRIPTOR: google.protobuf.descriptor.Descriptor
Expand Down Expand Up @@ -248,13 +228,35 @@ class LoggingConfig(google.protobuf.message.Message):
) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["config", b"config", "kind", b"kind"]) -> None: ...

class CouchbaseColumnarDestination(google.protobuf.message.Message):
DESCRIPTOR: google.protobuf.descriptor.Descriptor

DATABASE_FIELD_NUMBER: builtins.int
SCOPE_FIELD_NUMBER: builtins.int
COLLECTION_FIELD_NUMBER: builtins.int
database: builtins.str
"""Destination database name"""
scope: builtins.str
"""Destination scope name"""
collection: builtins.str
"""Destination collection name"""
def __init__(
self,
*,
database: builtins.str = ...,
scope: builtins.str = ...,
collection: builtins.str = ...,
) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["collection", b"collection", "database", b"database", "scope", b"scope"]) -> None: ...

SAMPLE_RATE_FIELD_NUMBER: builtins.int
FILE_DESTINATION_FIELD_NUMBER: builtins.int
BIGQUERY_DESTINATION_FIELD_NUMBER: builtins.int
REDSHIFT_DESTINATION_FIELD_NUMBER: builtins.int
SNOWFLAKE_DESTINATION_FIELD_NUMBER: builtins.int
CUSTOM_DESTINATION_FIELD_NUMBER: builtins.int
ATHENA_DESTINATION_FIELD_NUMBER: builtins.int
COUCHBASE_COLUMNAR_DESTINATION_FIELD_NUMBER: builtins.int
sample_rate: builtins.float
@property
def file_destination(self) -> global___LoggingConfig.FileDestination: ...
Expand All @@ -268,6 +270,8 @@ class LoggingConfig(google.protobuf.message.Message):
def custom_destination(self) -> global___LoggingConfig.CustomDestination: ...
@property
def athena_destination(self) -> global___LoggingConfig.AthenaDestination: ...
@property
def couchbase_columnar_destination(self) -> global___LoggingConfig.CouchbaseColumnarDestination: ...
def __init__(
self,
*,
Expand All @@ -280,9 +284,9 @@ class LoggingConfig(google.protobuf.message.Message):
athena_destination: global___LoggingConfig.AthenaDestination | None = ...,
couchbase_columnar_destination: global___LoggingConfig.CouchbaseColumnarDestination | None = ...,
) -> None: ...
def HasField(self, field_name: typing_extensions.Literal["athena_destination", b"athena_destination", "bigquery_destination", b"bigquery_destination", "custom_destination", b"custom_destination", "destination", b"destination", "file_destination", b"file_destination", "redshift_destination", b"redshift_destination", "snowflake_destination", b"snowflake_destination"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["athena_destination", b"athena_destination", "bigquery_destination", b"bigquery_destination", "custom_destination", b"custom_destination", "destination", b"destination", "file_destination", b"file_destination", "redshift_destination", b"redshift_destination", "sample_rate", b"sample_rate", "snowflake_destination", b"snowflake_destination"]) -> None: ...
def WhichOneof(self, oneof_group: typing_extensions.Literal["destination", b"destination"]) -> typing_extensions.Literal["file_destination", "bigquery_destination", "redshift_destination", "snowflake_destination", "custom_destination", "athena_destination"] | None: ...
def HasField(self, field_name: typing_extensions.Literal["athena_destination", b"athena_destination", "bigquery_destination", b"bigquery_destination", "couchbase_columnar_destination", b"couchbase_columnar_destination", "custom_destination", b"custom_destination", "destination", b"destination", "file_destination", b"file_destination", "redshift_destination", b"redshift_destination", "snowflake_destination", b"snowflake_destination"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["athena_destination", b"athena_destination", "bigquery_destination", b"bigquery_destination", "couchbase_columnar_destination", b"couchbase_columnar_destination", "custom_destination", b"custom_destination", "destination", b"destination", "file_destination", b"file_destination", "redshift_destination", b"redshift_destination", "sample_rate", b"sample_rate", "snowflake_destination", b"snowflake_destination"]) -> None: ...
def WhichOneof(self, oneof_group: typing_extensions.Literal["destination", b"destination"]) -> typing_extensions.Literal["file_destination", "bigquery_destination", "redshift_destination", "snowflake_destination", "custom_destination", "athena_destination", "couchbase_columnar_destination"] | None: ...

global___LoggingConfig = LoggingConfig

Expand Down